* [PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp()
@ 2017-05-03 21:22 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-05-03 21:22 UTC (permalink / raw)
To: James Smart
Cc: Dick Kennedy, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, kernel-janitors
There is a double lock bug here so this will deadlock instead of
unlocking.
Fixes: 1c5b12f76301 ("Fix implicit logo and RSCN handling for NVMET")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 1487406aea77..c7962dae4dab 100644
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -630,7 +630,7 @@ lpfc_ns_rsp(struct lpfc_vport *vport, struct lpfc_dmabuf *mp, uint8_t fc4_type,
NLP_EVT_DEVICE_RECOVERY);
spin_lock_irq(shost->host_lock);
ndlp->nlp_flag &= ~NLP_NVMET_RECOV;
- spin_lock_irq(shost->host_lock);
+ spin_unlock_irq(shost->host_lock);
}
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp()
@ 2017-05-03 21:22 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-05-03 21:22 UTC (permalink / raw)
To: James Smart
Cc: Dick Kennedy, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, kernel-janitors
There is a double lock bug here so this will deadlock instead of
unlocking.
Fixes: 1c5b12f76301 ("Fix implicit logo and RSCN handling for NVMET")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 1487406aea77..c7962dae4dab 100644
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -630,7 +630,7 @@ lpfc_ns_rsp(struct lpfc_vport *vport, struct lpfc_dmabuf *mp, uint8_t fc4_type,
NLP_EVT_DEVICE_RECOVERY);
spin_lock_irq(shost->host_lock);
ndlp->nlp_flag &= ~NLP_NVMET_RECOV;
- spin_lock_irq(shost->host_lock);
+ spin_unlock_irq(shost->host_lock);
}
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp()
2017-05-03 21:22 ` Dan Carpenter
@ 2017-05-03 21:46 ` James Smart
-1 siblings, 0 replies; 6+ messages in thread
From: James Smart @ 2017-05-03 21:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dick Kennedy, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, kernel-janitors
On 5/3/2017 2:22 PM, Dan Carpenter wrote:
> There is a double lock bug here so this will deadlock instead of
> unlocking.
>
> Fixes: 1c5b12f76301 ("Fix implicit logo and RSCN handling for NVMET")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
>
Yep. looks good
Reviewed-by: James Smart <james.smart@broadcom.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp()
@ 2017-05-03 21:46 ` James Smart
0 siblings, 0 replies; 6+ messages in thread
From: James Smart @ 2017-05-03 21:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dick Kennedy, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, kernel-janitors
On 5/3/2017 2:22 PM, Dan Carpenter wrote:
> There is a double lock bug here so this will deadlock instead of
> unlocking.
>
> Fixes: 1c5b12f76301 ("Fix implicit logo and RSCN handling for NVMET")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
>
Yep. looks good
Reviewed-by: James Smart <james.smart@broadcom.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp()
2017-05-03 21:22 ` Dan Carpenter
@ 2017-05-09 1:51 ` Martin K. Petersen
-1 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2017-05-09 1:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, kernel-janitors
Dan,
> There is a double lock bug here so this will deadlock instead of
> unlocking.
Applied to 4.12/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-09 1:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-03 21:22 [PATCH] scsi: lpfc: double lock typo in lpfc_ns_rsp() Dan Carpenter
2017-05-03 21:22 ` Dan Carpenter
2017-05-03 21:46 ` James Smart
2017-05-03 21:46 ` James Smart
2017-05-09 1:51 ` Martin K. Petersen
2017-05-09 1:51 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.