From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Anil Varughese <aniljoy@cadence.com>
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
pedrom.sousa@synopsys.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, hare@suse.de, rafalc@cadence.com,
mparab@cadence.com, jank@cadence.com, pawell@cadence.com,
vigneshr@ti.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS
Date: Wed, 07 Aug 2019 21:51:06 -0400 [thread overview]
Message-ID: <yq1wofoctmd.fsf@oracle.com> (raw)
In-Reply-To: <20190802112112.18714-1-aniljoy@cadence.com> (Anil Varughese's message of "Fri, 2 Aug 2019 12:21:12 +0100")
Anil,
> Configure CDNS_UFS_REG_HCLKDIV in .hce_enable_notify() instead of
> .setup_clock() because if UFSHCD resets the controller ip because
> of phy or device related errors then CDNS_UFS_REG_HCLKDIV is
> reset to default value and .setup_clock() is not called later
> in the sequence whereas .hce_enable_notify will be called everytime
> controller is reenabled.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Anil Varughese <aniljoy@cadence.com>
Cc: <alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
<pedrom.sousa@synopsys.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <hare@suse.de>,
<rafalc@cadence.com>, <mparab@cadence.com>, <jank@cadence.com>,
<pawell@cadence.com>, <vigneshr@ti.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS
Date: Wed, 07 Aug 2019 21:51:06 -0400 [thread overview]
Message-ID: <yq1wofoctmd.fsf@oracle.com> (raw)
Message-ID: <20190808015106.14PKdxc47QRTWyt0pXJoRn62FlulmhS2J1x4PTi8lqk@z> (raw)
In-Reply-To: <20190802112112.18714-1-aniljoy@cadence.com> (Anil Varughese's message of "Fri, 2 Aug 2019 12:21:12 +0100")
Anil,
> Configure CDNS_UFS_REG_HCLKDIV in .hce_enable_notify() instead of
> .setup_clock() because if UFSHCD resets the controller ip because
> of phy or device related errors then CDNS_UFS_REG_HCLKDIV is
> reset to default value and .setup_clock() is not called later
> in the sequence whereas .hce_enable_notify will be called everytime
> controller is reenabled.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-08-08 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 11:21 [PATCH v2] scsi: ufs: Configure clock in .hce_enable_notify() in Cadence UFS Anil Varughese
2019-08-02 11:21 ` Anil Varughese
2019-08-05 8:02 ` Vignesh Raghavendra
2019-08-05 8:02 ` Vignesh Raghavendra
2019-08-08 1:51 ` Martin K. Petersen [this message]
2019-08-08 1:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wofoctmd.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=alim.akhtar@samsung.com \
--cc=aniljoy@cadence.com \
--cc=avri.altman@wdc.com \
--cc=hare@suse.de \
--cc=jank@cadence.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mparab@cadence.com \
--cc=pawell@cadence.com \
--cc=pedrom.sousa@synopsys.com \
--cc=rafalc@cadence.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.