* [PATCH V2] hpsa: remove coalescing settings for ioaccel2
@ 2017-01-30 22:05 Don Brace
2017-02-01 2:51 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Don Brace @ 2017-01-30 22:05 UTC (permalink / raw)
To: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara,
bader.alisaleh, hch, scott.teel, Viswas.G, Justin.Lindley,
scott.benesh, elliott, POSWALD
Cc: linux-scsi
- Setting coalescing has a significant negative
impact on low queue-depth performance.
- Does not help high queue-depth performance.
Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index cbc0c5f..4323ddc 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9263,13 +9263,9 @@ static int hpsa_enter_performant_mode(struct ctlr_info *h, u32 trans_support)
access = SA5_ioaccel_mode1_access;
writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
writel(4, &h->cfgtable->HostWrite.CoalIntCount);
- } else {
- if (trans_support & CFGTBL_Trans_io_accel2) {
+ } else
+ if (trans_support & CFGTBL_Trans_io_accel2)
access = SA5_ioaccel_mode2_access;
- writel(10, &h->cfgtable->HostWrite.CoalIntDelay);
- writel(4, &h->cfgtable->HostWrite.CoalIntCount);
- }
- }
writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL);
if (hpsa_wait_for_mode_change_ack(h)) {
dev_err(&h->pdev->dev,
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH V2] hpsa: remove coalescing settings for ioaccel2
2017-01-30 22:05 [PATCH V2] hpsa: remove coalescing settings for ioaccel2 Don Brace
@ 2017-02-01 2:51 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2017-02-01 2:51 UTC (permalink / raw)
To: Don Brace
Cc: jejb, john.hall, Kevin.Barnett, Mahesh.Rajashekhara,
bader.alisaleh, hch, scott.teel, Viswas.G, Justin.Lindley,
scott.benesh, elliott, POSWALD, linux-scsi
>>>>> "Don" == Don Brace <don.brace@microsemi.com> writes:
Don> - Setting coalescing has a significant negative impact on low
Don> queue-depth performance. - Does not help high queue-depth
Don> performance.
Applied to 4.11/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-01 2:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-30 22:05 [PATCH V2] hpsa: remove coalescing settings for ioaccel2 Don Brace
2017-02-01 2:51 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.