From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: James Morris <jmorris@namei.org>,
devel@driverdev.osuosl.org, Hannes Reinecke <hare@suse.com>,
linux-scsi@vger.kernel.org,
James Smart <james.smart@broadcom.com>,
lvs-devel@vger.kernel.org, Julian Anastasov <ja@ssi.bg>,
coreteam@netfilter.org, Pablo Neira Ayuso <pablo@netfilter.org>,
Wensong Zhang <wensong@linux-vs.org>,
Dick Kennedy <dick.kennedy@broadcom.com>,
Kees Cook <keescook@chromium.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Silvio Cesare <silvio.cesare@gmail.com>,
Simon Horman <horms@verge.net.au>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Willy Tarreau <w@1wt.eu>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Larr
Subject: Re: [PATCH 2/4] lpfc: reduce stack size with CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE
Date: Thu, 11 Jul 2019 20:47:03 -0400 [thread overview]
Message-ID: <yq1y3146pvc.fsf@oracle.com> (raw)
In-Reply-To: <20190628123819.2785504-2-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 28 Jun 2019 14:37:47 +0200")
Arnd,
> The lpfc_debug_dump_all_queues() function repeatedly calls into
> lpfc_debug_dump_qe(), which has a temporary 128 byte buffer. This was
> fine before the introduction of CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE
> because each instance could occupy the same stack slot. However, now
> they each get their own copy, which leads to a huge increase in stack
> usage as seen from the compiler warning:
Applied to 5.3/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kees Cook <keescook@chromium.org>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
Wensong Zhang <wensong@linux-vs.org>,
Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>,
Pablo Neira Ayuso <pablo@netfilter.org>,
James Morris <jmorris@namei.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, netdev@vger.kernel.org,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Hannes Reinecke <hare@suse.com>, Willy Tarreau <w@1wt.eu>,
Silvio Cesare <silvio.cesare@gmail.com>
Subject: Re: [PATCH 2/4] lpfc: reduce stack size with CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE
Date: Thu, 11 Jul 2019 20:47:03 -0400 [thread overview]
Message-ID: <yq1y3146pvc.fsf@oracle.com> (raw)
In-Reply-To: <20190628123819.2785504-2-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 28 Jun 2019 14:37:47 +0200")
Arnd,
> The lpfc_debug_dump_all_queues() function repeatedly calls into
> lpfc_debug_dump_qe(), which has a temporary 128 byte buffer. This was
> fine before the introduction of CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE
> because each instance could occupy the same stack slot. However, now
> they each get their own copy, which leads to a huge increase in stack
> usage as seen from the compiler warning:
Applied to 5.3/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-07-12 0:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 12:37 [PATCH 1/4] [v2] structleak: disable STRUCTLEAK_BYREF in combination with KASAN_STACK Arnd Bergmann
2019-06-28 12:37 ` Arnd Bergmann
2019-06-28 12:37 ` [PATCH 2/4] lpfc: reduce stack size with CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE Arnd Bergmann
2019-06-28 18:57 ` James Smart
2019-07-12 0:47 ` Martin K. Petersen [this message]
2019-07-12 0:47 ` Martin K. Petersen
2019-06-28 12:37 ` [PATCH 3/4] staging: rtl8712: reduce stack usage, again Arnd Bergmann
2019-06-28 19:52 ` Willem de Bruijn
2019-06-28 19:52 ` Willem de Bruijn
2019-06-28 12:37 ` [PATCH 4/4] ipvs: reduce kernel stack usage Arnd Bergmann
2019-06-28 19:50 ` Willem de Bruijn
2019-06-28 19:50 ` Willem de Bruijn
2019-07-22 10:28 ` Arnd Bergmann
2019-07-22 10:28 ` Arnd Bergmann
2019-06-30 20:36 ` Julian Anastasov
2019-06-30 20:36 ` Julian Anastasov
2019-07-22 10:16 ` Arnd Bergmann
2019-07-22 10:16 ` Arnd Bergmann
2019-06-28 14:48 ` [PATCH 1/4] [v2] structleak: disable STRUCTLEAK_BYREF in combination with KASAN_STACK Kees Cook
2019-06-28 14:48 ` Kees Cook
2019-06-28 14:48 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y3146pvc.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=dick.kennedy@broadcom.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=silvio.cesare@gmail.com \
--cc=w@1wt.eu \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.