From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Ching Huang <ching2048@areca.com.tw>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] scsi: arcmsr: remove redundant check for secs < 0
Date: Tue, 12 Dec 2017 02:37:47 +0000 [thread overview]
Message-ID: <yq1y3m8r7r8.fsf@oracle.com> (raw)
In-Reply-To: <20171209003414.17332-1-colin.king@canonical.com> (Colin King's message of "Sat, 9 Dec 2017 00:34:14 +0000")
Colin,
> The check for secs being less than zero is redundant for two reasons.
> Firstly, secs is unsigned so the check is always going to be false.
> Secondly, if secs was signed the proceeding calculation of secs is
> never going to be negative. Hence we can remove this redundant check
> and day and secs re-adjustment.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Ching Huang <ching2048@areca.com.tw>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] scsi: arcmsr: remove redundant check for secs < 0
Date: Mon, 11 Dec 2017 21:37:47 -0500 [thread overview]
Message-ID: <yq1y3m8r7r8.fsf@oracle.com> (raw)
In-Reply-To: <20171209003414.17332-1-colin.king@canonical.com> (Colin King's message of "Sat, 9 Dec 2017 00:34:14 +0000")
Colin,
> The check for secs being less than zero is redundant for two reasons.
> Firstly, secs is unsigned so the check is always going to be false.
> Secondly, if secs was signed the proceeding calculation of secs is
> never going to be negative. Hence we can remove this redundant check
> and day and secs re-adjustment.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-12-12 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 0:34 [PATCH][next] scsi: arcmsr: remove redundant check for secs < 0 Colin King
2017-12-09 0:34 ` Colin King
2017-12-11 2:41 ` 黃清隆
2017-12-11 2:41 ` 黃清隆
2017-12-12 2:37 ` Martin K. Petersen [this message]
2017-12-12 2:37 ` Martin K. Petersen
2017-12-15 17:52 ` walter harms
2017-12-15 17:52 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y3m8r7r8.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=ching2048@areca.com.tw \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.