All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: James Smart <james.smart@broadcom.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: lpfc: spin_lock_irq() is not nestable
Date: Sat, 01 Jul 2017 21:09:45 +0000	[thread overview]
Message-ID: <yq1y3s7vp7q.fsf@oracle.com> (raw)
In-Reply-To: <20170630080250.mjbosf64qlytrsii@mwanda> (Dan Carpenter's message of "Fri, 30 Jun 2017 11:02:51 +0300")


Dan,

> We're calling spin_lock_irq() multiple times, the problem is that on
> the first spin_unlock_irq() then we will re-enable IRQs and we don't
> want that.

Applied to 4.13/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: James Smart <james.smart@broadcom.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: lpfc: spin_lock_irq() is not nestable
Date: Sat, 01 Jul 2017 17:09:45 -0400	[thread overview]
Message-ID: <yq1y3s7vp7q.fsf@oracle.com> (raw)
In-Reply-To: <20170630080250.mjbosf64qlytrsii@mwanda> (Dan Carpenter's message of "Fri, 30 Jun 2017 11:02:51 +0300")


Dan,

> We're calling spin_lock_irq() multiple times, the problem is that on
> the first spin_unlock_irq() then we will re-enable IRQs and we don't
> want that.

Applied to 4.13/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2017-07-01 21:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30  8:02 [PATCH 1/2] scsi: lpfc: spin_lock_irq() is not nestable Dan Carpenter
2017-06-30  8:02 ` Dan Carpenter
2017-06-30  8:03 ` [PATCH 2/2] scsi: lpfc: don't double count abort errors Dan Carpenter
2017-06-30  8:03   ` Dan Carpenter
2017-06-30 14:56   ` James Smart
2017-06-30 14:56     ` James Smart
2017-07-01 21:09   ` Martin K. Petersen
2017-07-01 21:09     ` Martin K. Petersen
2017-06-30 14:56 ` [PATCH 1/2] scsi: lpfc: spin_lock_irq() is not nestable James Smart
2017-06-30 14:56   ` James Smart
2017-07-01 21:09 ` Martin K. Petersen [this message]
2017-07-01 21:09   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1y3s7vp7q.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=james.smart@broadcom.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.