* [PATCH] scsi: remove show_use_blk_mq()
@ 2020-04-01 13:40 Jason Yan
2020-04-01 13:51 ` John Garry
2020-04-01 14:29 ` Steffen Maier
0 siblings, 2 replies; 6+ messages in thread
From: Jason Yan @ 2020-04-01 13:40 UTC (permalink / raw)
To: martin.petersen, jejb
Cc: linux-scsi, Jason Yan, Ewan D . Milne, Christoph Hellwig,
Hannes Reinecke, Bart Van Assche, Ming Lei, John Garry
This code is useless now so remove it.
Cc: Ewan D. Milne <emilne@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Cc: Hannes Reinecke <hare@suse.de>
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: John Garry <john.garry@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/scsi_sysfs.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 163dbcb741c1..6480e27982ab 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -386,15 +386,7 @@ show_host_busy(struct device *dev, struct device_attribute *attr, char *buf)
}
static DEVICE_ATTR(host_busy, S_IRUGO, show_host_busy, NULL);
-static ssize_t
-show_use_blk_mq(struct device *dev, struct device_attribute *attr, char *buf)
-{
- return sprintf(buf, "1\n");
-}
-static DEVICE_ATTR(use_blk_mq, S_IRUGO, show_use_blk_mq, NULL);
-
static struct attribute *scsi_sysfs_shost_attrs[] = {
- &dev_attr_use_blk_mq.attr,
&dev_attr_unique_id.attr,
&dev_attr_host_busy.attr,
&dev_attr_cmd_per_lun.attr,
--
2.17.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: remove show_use_blk_mq()
2020-04-01 13:40 [PATCH] scsi: remove show_use_blk_mq() Jason Yan
@ 2020-04-01 13:51 ` John Garry
2020-04-02 1:19 ` Jason Yan
2020-04-01 14:29 ` Steffen Maier
1 sibling, 1 reply; 6+ messages in thread
From: John Garry @ 2020-04-01 13:51 UTC (permalink / raw)
To: Jason Yan, martin.petersen, jejb
Cc: linux-scsi, Ewan D . Milne, Christoph Hellwig, Hannes Reinecke,
Bart Van Assche, Ming Lei
On 01/04/2020 14:40, Jason Yan wrote:
> This code is useless now so remove it.
>
note: I did not delete this in "scsi: core: Delete scsi_use_blk_mq", to
avoid risk of breaking some user still using this
thanks,
John
> Cc: Ewan D. Milne <emilne@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>,
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: John Garry <john.garry@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/scsi/scsi_sysfs.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 163dbcb741c1..6480e27982ab 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -386,15 +386,7 @@ show_host_busy(struct device *dev, struct device_attribute *attr, char *buf)
> }
> static DEVICE_ATTR(host_busy, S_IRUGO, show_host_busy, NULL);
>
> -static ssize_t
> -show_use_blk_mq(struct device *dev, struct device_attribute *attr, char *buf)
> -{
> - return sprintf(buf, "1\n");
> -}
> -static DEVICE_ATTR(use_blk_mq, S_IRUGO, show_use_blk_mq, NULL);
> -
> static struct attribute *scsi_sysfs_shost_attrs[] = {
> - &dev_attr_use_blk_mq.attr,
> &dev_attr_unique_id.attr,
> &dev_attr_host_busy.attr,
> &dev_attr_cmd_per_lun.attr,
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: remove show_use_blk_mq()
2020-04-01 13:51 ` John Garry
@ 2020-04-02 1:19 ` Jason Yan
2020-04-02 2:06 ` Martin K. Petersen
0 siblings, 1 reply; 6+ messages in thread
From: Jason Yan @ 2020-04-02 1:19 UTC (permalink / raw)
To: John Garry, martin.petersen, jejb
Cc: linux-scsi, Ewan D . Milne, Christoph Hellwig, Hannes Reinecke,
Bart Van Assche, Ming Lei
在 2020/4/1 21:51, John Garry 写道:
> On 01/04/2020 14:40, Jason Yan wrote:
>> This code is useless now so remove it.
>>
>
> note: I did not delete this in "scsi: core: Delete scsi_use_blk_mq", to
> avoid risk of breaking some user still using this
>
Maybe. But removing a module param may break the user space too.
Actually when the legacy path of single queue is removed, plenty of sys
attributes have been removed. And this one needs to go sooner or later.
> thanks,
> John
>
>> Cc: Ewan D. Milne <emilne@redhat.com>
>> Cc: Christoph Hellwig <hch@lst.de>,
>> Cc: Hannes Reinecke <hare@suse.de>
>> Cc: Bart Van Assche <bvanassche@acm.org>
>> Cc: Ming Lei <ming.lei@redhat.com>
>> Cc: John Garry <john.garry@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> drivers/scsi/scsi_sysfs.c | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
>> index 163dbcb741c1..6480e27982ab 100644
>> --- a/drivers/scsi/scsi_sysfs.c
>> +++ b/drivers/scsi/scsi_sysfs.c
>> @@ -386,15 +386,7 @@ show_host_busy(struct device *dev, struct
>> device_attribute *attr, char *buf)
>> }
>> static DEVICE_ATTR(host_busy, S_IRUGO, show_host_busy, NULL);
>> -static ssize_t
>> -show_use_blk_mq(struct device *dev, struct device_attribute *attr,
>> char *buf)
>> -{
>> - return sprintf(buf, "1\n");
>> -}
>> -static DEVICE_ATTR(use_blk_mq, S_IRUGO, show_use_blk_mq, NULL);
>> -
>> static struct attribute *scsi_sysfs_shost_attrs[] = {
>> - &dev_attr_use_blk_mq.attr,
>> &dev_attr_unique_id.attr,
>> &dev_attr_host_busy.attr,
>> &dev_attr_cmd_per_lun.attr,
>>
>
>
> .
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: remove show_use_blk_mq()
2020-04-02 1:19 ` Jason Yan
@ 2020-04-02 2:06 ` Martin K. Petersen
2020-04-02 2:24 ` Jason Yan
0 siblings, 1 reply; 6+ messages in thread
From: Martin K. Petersen @ 2020-04-02 2:06 UTC (permalink / raw)
To: Jason Yan
Cc: John Garry, martin.petersen, jejb, linux-scsi, Ewan D . Milne,
Christoph Hellwig, Hannes Reinecke, Bart Van Assche, Ming Lei
Jason,
> Maybe. But removing a module param may break the user space too.
It won't break loading the module.
The intent is to leave the sysfs parameter in place for a while to make
sure nobody depends on it.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: remove show_use_blk_mq()
2020-04-02 2:06 ` Martin K. Petersen
@ 2020-04-02 2:24 ` Jason Yan
0 siblings, 0 replies; 6+ messages in thread
From: Jason Yan @ 2020-04-02 2:24 UTC (permalink / raw)
To: Martin K. Petersen
Cc: John Garry, jejb, linux-scsi, Ewan D . Milne, Christoph Hellwig,
Hannes Reinecke, Bart Van Assche, Ming Lei
在 2020/4/2 10:06, Martin K. Petersen 写道:
>
> Jason,
>
>> Maybe. But removing a module param may break the user space too.
>
> It won't break loading the module.
>
> The intent is to leave the sysfs parameter in place for a while to make
> sure nobody depends on it.
>
OK, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: remove show_use_blk_mq()
2020-04-01 13:40 [PATCH] scsi: remove show_use_blk_mq() Jason Yan
2020-04-01 13:51 ` John Garry
@ 2020-04-01 14:29 ` Steffen Maier
1 sibling, 0 replies; 6+ messages in thread
From: Steffen Maier @ 2020-04-01 14:29 UTC (permalink / raw)
To: Jason Yan, martin.petersen, jejb
Cc: linux-scsi, Ewan D . Milne, Christoph Hellwig, Hannes Reinecke,
Bart Van Assche, Ming Lei, John Garry, Greg Kroah-Hartman,
Benjamin Block
On 4/1/20 3:40 PM, Jason Yan wrote:
> This code is useless now so remove it.
>
> Cc: Ewan D. Milne <emilne@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>,
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: John Garry <john.garry@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/scsi/scsi_sysfs.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 163dbcb741c1..6480e27982ab 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -386,15 +386,7 @@ show_host_busy(struct device *dev, struct device_attribute *attr, char *buf)
> }
> static DEVICE_ATTR(host_busy, S_IRUGO, show_host_busy, NULL);
>
> -static ssize_t
> -show_use_blk_mq(struct device *dev, struct device_attribute *attr, char *buf)
> -{
> - return sprintf(buf, "1\n");
> -}
> -static DEVICE_ATTR(use_blk_mq, S_IRUGO, show_use_blk_mq, NULL);
> -
> static struct attribute *scsi_sysfs_shost_attrs[] = {
> - &dev_attr_use_blk_mq.attr,
Looks like the removal of a sysfs attribute.
Wouldn't this break user space ABI?
I checked Documentation/ABI/ but could not find this attribute having been
obsolete (but it does not seem testing or stable either).
[linux/Documentation/ABI](0)$ git grep use_blk_mq .
testing/sysfs-block-dm:41:What: /sys/block/dm-<num>/dm/use_blk_mq
> &dev_attr_unique_id.attr,
> &dev_attr_host_busy.attr,
> &dev_attr_cmd_per_lun.attr,
>
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z Development
https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-02 2:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-01 13:40 [PATCH] scsi: remove show_use_blk_mq() Jason Yan
2020-04-01 13:51 ` John Garry
2020-04-02 1:19 ` Jason Yan
2020-04-02 2:06 ` Martin K. Petersen
2020-04-02 2:24 ` Jason Yan
2020-04-01 14:29 ` Steffen Maier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.