All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Schnelle <svens@linux.ibm.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2] kprobes: convert tests to kunit
Date: Sat, 25 Sep 2021 08:39:30 +0200	[thread overview]
Message-ID: <yt9d8rzlgnvh.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210925104726.043885d4c8f7ec80de2746c9@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

Hi Masami,

Masami Hiramatsu <mhiramat@kernel.org> writes:

> On Fri, 24 Sep 2021 20:19:20 +0200
> Sven Schnelle <svens@linux.ibm.com> wrote:
>
>> kernel test robot <lkp@intel.com> writes:
>> 
>> > Hi Sven,
>> >
>> > Thank you for the patch! Yet something to improve:
>> >
>> [..]
>> >    ia64-linux-ld: kernel/test_kprobes.o: in function `entry_handler':
>> >>> test_kprobes.c:(.text+0x150): undefined reference to `kunit_unary_assert_format'
>> >>> ia64-linux-ld: test_kprobes.c:(.text+0x212): undefined reference to `kunit_do_assertion'
>> >    ia64-linux-ld: kernel/test_kprobes.o: in function `return_handler2':
>> >>> test_kprobes.c:(.text+0x2f0): undefined reference to `kunit_binary_assert_format'
>> >    ia64-linux-ld: test_kprobes.c:(.text+0x452): undefined reference to `kunit_do_assertion'
>> >    ia64-linux-ld: test_kprobes.c:(.text+0x522): undefined reference to `kunit_do_assertion'
>> 
>> I missed that kunit can be built as module. I'll fix it an send a v3.
>
> Does this mean we can not use KUnit for the feature which is not exposed to module?

I changed the test_kprobes so that it can be build as a module now. (i
guess you already noticed that when looking at the v3 patch).

WARNING: multiple messages have this Message-ID (diff)
From: Sven Schnelle <svens@linux.ibm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
	"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kprobes: convert tests to kunit
Date: Sat, 25 Sep 2021 08:39:30 +0200	[thread overview]
Message-ID: <yt9d8rzlgnvh.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210925104726.043885d4c8f7ec80de2746c9@kernel.org> (Masami Hiramatsu's message of "Sat, 25 Sep 2021 10:47:26 +0900")

Hi Masami,

Masami Hiramatsu <mhiramat@kernel.org> writes:

> On Fri, 24 Sep 2021 20:19:20 +0200
> Sven Schnelle <svens@linux.ibm.com> wrote:
>
>> kernel test robot <lkp@intel.com> writes:
>> 
>> > Hi Sven,
>> >
>> > Thank you for the patch! Yet something to improve:
>> >
>> [..]
>> >    ia64-linux-ld: kernel/test_kprobes.o: in function `entry_handler':
>> >>> test_kprobes.c:(.text+0x150): undefined reference to `kunit_unary_assert_format'
>> >>> ia64-linux-ld: test_kprobes.c:(.text+0x212): undefined reference to `kunit_do_assertion'
>> >    ia64-linux-ld: kernel/test_kprobes.o: in function `return_handler2':
>> >>> test_kprobes.c:(.text+0x2f0): undefined reference to `kunit_binary_assert_format'
>> >    ia64-linux-ld: test_kprobes.c:(.text+0x452): undefined reference to `kunit_do_assertion'
>> >    ia64-linux-ld: test_kprobes.c:(.text+0x522): undefined reference to `kunit_do_assertion'
>> 
>> I missed that kunit can be built as module. I'll fix it an send a v3.
>
> Does this mean we can not use KUnit for the feature which is not exposed to module?

I changed the test_kprobes so that it can be build as a module now. (i
guess you already noticed that when looking at the v3 patch).

  reply	other threads:[~2021-09-25  6:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  7:08 [PATCH v2] kprobes: convert tests to kunit Sven Schnelle
2021-09-14 12:19 ` Masami Hiramatsu
2021-09-14 21:56 ` kernel test robot
2021-09-14 21:56   ` kernel test robot
2021-09-24 18:19   ` Sven Schnelle
2021-09-24 18:19     ` Sven Schnelle
2021-09-25  1:47     ` Masami Hiramatsu
2021-09-25  1:47       ` Masami Hiramatsu
2021-09-25  6:39       ` Sven Schnelle [this message]
2021-09-25  6:39         ` Sven Schnelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yt9d8rzlgnvh.fsf@linux.ibm.com \
    --to=svens@linux.ibm.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.