Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

From: Sven Schnelle <svens@linux.ibm.com>
To: "Dmitry V. Levin" <ldv@strace.io>
Cc: linux-snps-arc@lists.infradead.org, Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andreas Larsson <andreas@gaisler.com>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Guo Ren <guoren@kernel.org>,
	linux-csky@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org,
	WANG Xuerui <kernel@xen0n.name>, Will Deacon <will@kernel.org>,
	Eugene Syromyatnikov <evgsyr@gmail.com>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Jonas Bonn <jonas@southpole.se>,
	linux-s390@vger.kernel.org,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	linux-sh@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
	Helge Deller <deller@gmx.de>, Huacai Chen <chenhuacai@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>, Vineet Gupta <vgupta@kernel.org>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	strace-devel@lists.strace.io, linux-arch@vger.kernel.org,
	Albert Ou <aou@eecs.berkeley.edu>,
	Mike Frysinger <vapier@gentoo.org>,
	Davide Berardi <berardi.dav@gmail.com>,
	Renzo Davoli <renzo@cs.unibo.it>,
	linux-um@lists.infradead.org, Heiko Carstens <hca@linux.ibm.com>,
	Charlie Jenkins <charlie@rivosinc.com>,
	Naveen N Rao <naveen@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	Borislav Petkov <bp@alien8.de>,
	loongarch@lists.linux.dev,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Stafford Horne <shorne@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Brian Cain <bcain@quicinc.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-parisc@vger.kernel.org, linux-openrisc@vger.kernel.org,
	linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Oleg Nesterov <oleg@redhat.com>,
	Dinh Nguyen <dinguyen@kernel.org>,
	linux-riscv@lists.infradead.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Richard Weinberger <richard@nod.at>,
	Johannes Berg <johannes@sipsolutions.net>,
	Alexey Gladkov <legion@kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return_value()
Date: Thu, 30 Jan 2025 12:36:29 +0100	[thread overview]
Message-ID: <yt9dsep0y1mq.fsf@linux.ibm.com> (raw)
In-Reply-To: <20250130112207.GA6617@strace.io> (Dmitry V. Levin's message of "Thu, 30 Jan 2025 13:22:07 +0200")

"Dmitry V. Levin" <ldv@strace.io> writes:

> On Thu, Jan 30, 2025 at 09:33:03AM +0100, Sven Schnelle wrote:
>> "Dmitry V. Levin" <ldv@strace.io> writes:
>> 
>> > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK
>> > architectures to implement PTRACE_SET_SYSCALL_INFO API.
>> >
>> > This partially reverts commit 7962c2eddbfe ("arch: remove unused
>> > function syscall_set_arguments()") by reusing some of old
>> > syscall_set_arguments() implementations.
>> >
>> > Signed-off-by: Dmitry V. Levin <ldv@strace.io>
>> > Tested-by: Charlie Jenkins <charlie@rivosinc.com>
>> > Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
>> > ---
>> >  arch/arc/include/asm/syscall.h        | 14 +++++++++++
>> >  arch/arm/include/asm/syscall.h        | 13 ++++++++++
>> >  arch/arm64/include/asm/syscall.h      | 13 ++++++++++
>> >  arch/csky/include/asm/syscall.h       | 13 ++++++++++
>> >  arch/hexagon/include/asm/syscall.h    | 14 +++++++++++
>> >  arch/loongarch/include/asm/syscall.h  |  8 ++++++
>> >  arch/mips/include/asm/syscall.h       | 32 ++++++++++++++++++++++++
>> >  arch/nios2/include/asm/syscall.h      | 11 ++++++++
>> >  arch/openrisc/include/asm/syscall.h   |  7 ++++++
>> >  arch/parisc/include/asm/syscall.h     | 12 +++++++++
>> >  arch/powerpc/include/asm/syscall.h    | 10 ++++++++
>> >  arch/riscv/include/asm/syscall.h      |  9 +++++++
>> >  arch/s390/include/asm/syscall.h       | 12 +++++++++
>> >  arch/sh/include/asm/syscall_32.h      | 12 +++++++++
>> >  arch/sparc/include/asm/syscall.h      | 10 ++++++++
>> >  arch/um/include/asm/syscall-generic.h | 14 +++++++++++
>> >  arch/x86/include/asm/syscall.h        | 36 +++++++++++++++++++++++++++
>> >  arch/xtensa/include/asm/syscall.h     | 11 ++++++++
>> >  include/asm-generic/syscall.h         | 16 ++++++++++++
>> >  19 files changed, 267 insertions(+)
>> >
>> > diff --git a/arch/s390/include/asm/syscall.h b/arch/s390/include/asm/syscall.h
>> > index 27e3d804b311..b3dd883699e7 100644
>> > --- a/arch/s390/include/asm/syscall.h
>> > +++ b/arch/s390/include/asm/syscall.h
>> > @@ -78,6 +78,18 @@ static inline void syscall_get_arguments(struct task_struct *task,
>> >  	args[0] = regs->orig_gpr2 & mask;
>> >  }
>> >  
>> > +static inline void syscall_set_arguments(struct task_struct *task,
>> > +					 struct pt_regs *regs,
>> > +					 const unsigned long *args)
>> > +{
>> > +	unsigned int n = 6;
>> > +
>> > +	while (n-- > 0)
>> > +		if (n > 0)
>> > +			regs->gprs[2 + n] = args[n];
>> > +	regs->orig_gpr2 = args[0];
>> > +}
>> 
>> Could that be changed to something like:
>> 
>> for (int n = 1; n < 6; n++)
>>         regs->gprs[2 + n] = args[n];
>> regs->orig_gpr2 = args[0];
>> 
>> I think this is way easier to parse.
>
> I don't mind changing syscall_set_arguments() this way, but it just
> mirrors syscall_get_arguments(), so I think it would be better if these
> two functions were written in the same style.  Would you like to change
> syscall_get_arguments() as well?

Oh. I'll prepare a patch for syscall_get_arguments(), wasn't aware
that this function looks the same. I'll send this via the s390 tree, so
it's independent of your patch series. Thanks!