From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Eric Anholt <eric@anholt.net>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Revert "drm/i915: Kill GTT mappings when moving from GTT domain"
Date: Tue, 21 Jun 2011 11:09:05 -0700 [thread overview]
Message-ID: <yun62nzxdj2.fsf@aiko.keithp.com> (raw)
In-Reply-To: <013811$h8tfb@fmsmga002.fm.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 734 bytes --]
On Sun, 19 Jun 2011 22:49:36 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The patch closes a race condition. The essence of your complaint is that
> the kernel is not as fast as we need it to be, and that the initial upload
> to any object is slower than expected. I presume you also have a plan for
> fixing the underwhelming performance of a glibc memcpy through an
> established GTT mapping?
I see a performance regression in a critical path for most applications
(texture upload), and I'm not seeing any bug report that your fix
closes. That seems pretty conclusive to me; I'll plan on pushing a
revert of this patch to eliminate the regression from the previous
version.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2011-06-21 18:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 23:43 [PATCH] Revert "drm/i915: Kill GTT mappings when moving from GTT domain" Eric Anholt
2011-06-15 9:39 ` Chris Wilson
2011-06-15 15:08 ` Eric Anholt
2011-06-15 16:03 ` Chris Wilson
2011-06-17 19:06 ` Eric Anholt
2011-06-18 11:43 ` Chris Wilson
2011-06-18 20:20 ` Eric Anholt
2011-06-19 16:28 ` Chris Wilson
2011-06-19 17:01 ` Eric Anholt
2011-06-19 17:14 ` Chris Wilson
2011-06-19 21:20 ` Eric Anholt
2011-06-19 21:49 ` Chris Wilson
2011-06-21 16:17 ` Remove the overhead of vm_insert_pfn() Chris Wilson
2011-06-21 16:17 ` [PATCH 1/3] resource: Use a common string for .name = "System RAM" Chris Wilson
2011-06-21 16:17 ` [PATCH 2/3] x86, pat: Perform interval rbtree lookup of memtype first Chris Wilson
2011-06-21 16:17 ` [PATCH 3/3] x86, pat: Convert memtype_lock spinlock to a rwlock Chris Wilson
2011-06-21 18:09 ` Keith Packard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yun62nzxdj2.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=chris@chris-wilson.co.uk \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.