All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Adam Jackson <ajax@redhat.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required
Date: Fri, 14 Oct 2011 23:11:52 -0700	[thread overview]
Message-ID: <yunaa92zsuv.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1318610630-20459-1-git-send-email-ajax@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 515 bytes --]

On Fri, 14 Oct 2011 12:43:49 -0400, Adam Jackson <ajax@redhat.com> wrote:

> The previous code was confused about units, which is pretty reasonable
> given that the units themselves are confusing.

Thanks for actually figuring this out; the comment before that function
should have indicated to any reader that I couldn't figure out what that
computation should have been.

One question -- do you have an example of where the old computation
failed and the new one works?

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2011-10-15  6:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-14 16:43 [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required Adam Jackson
2011-10-14 16:43 ` [PATCH 2/2] drm/i915/dp: Remove eDP special cases from bandwidth checks Adam Jackson
2011-10-15  6:13   ` Keith Packard
2011-10-17 17:29     ` Adam Jackson
2012-05-10 18:40       ` Chris Wilson
2012-05-10 19:14         ` Daniel Vetter
2011-10-15  6:11 ` Keith Packard [this message]
2011-10-17 17:03   ` [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required Adam Jackson
2011-10-17 22:46     ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yunaa92zsuv.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=ajax@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.