All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>,
	linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 1/2] drm: Add Panel Self Refresh DP addresses
Date: Mon, 03 Oct 2011 14:25:39 -0700	[thread overview]
Message-ID: <yunaa9hn4x8.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1316557787-14935-1-git-send-email-ben@bwidawsk.net>

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

On Tue, 20 Sep 2011 15:29:47 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:

> Add the addresses and definitions I care about for Panel Self Refresh, as
> documented in the eDP spec.

I generally review the addresses and bit definitions for any new
registers -- getting them wrong makes debugging the code really hard. I
couldn't find these in a brief search through the bspec. Can you point
out where they are?

-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Keith Packard <keithp@keithp.com>
To: intel-gfx@lists.freedesktop.org
Cc: Dave Airlie <airlied@redhat.com>, Ben Widawsky <ben@bwidawsk.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm: Add Panel Self Refresh DP addresses
Date: Mon, 03 Oct 2011 14:25:39 -0700	[thread overview]
Message-ID: <yunaa9hn4x8.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1316557787-14935-1-git-send-email-ben@bwidawsk.net>


[-- Attachment #1.1: Type: text/plain, Size: 452 bytes --]

On Tue, 20 Sep 2011 15:29:47 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:

> Add the addresses and definitions I care about for Panel Self Refresh, as
> documented in the eDP spec.

I generally review the addresses and bit definitions for any new
registers -- getting them wrong makes debugging the code really hard. I
couldn't find these in a brief search through the bspec. Can you point
out where they are?

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-10-03 21:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-20 22:29 [PATCH 1/2] drm: Add Panel Self Refresh DP addresses Ben Widawsky
2011-09-20 22:29 ` Ben Widawsky
2011-10-03 21:25 ` Keith Packard [this message]
2011-10-03 21:25   ` Keith Packard
2011-10-03 22:14   ` Ben Widawsky
2011-10-03 23:31     ` Keith Packard
2011-10-04  2:38       ` Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yunaa9hn4x8.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=airlied@redhat.com \
    --cc=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.