From: Keith Packard <keithp@keithp.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Fix recursive calls to unmap
Date: Sun, 30 Oct 2011 19:35:11 -0700 [thread overview]
Message-ID: <yunbosx3n34.fsf@aiko.keithp.com> (raw)
In-Reply-To: <20111030185210.6d3a74d4@bwidawsk.net>
[-- Attachment #1.1: Type: text/plain, Size: 631 bytes --]
On Sun, 30 Oct 2011 18:52:10 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> Well, I had to pick one, and looking at the call chain, it seemed there wasn't
> much to gain by doing retiring at this point.
The point is that you're mixing the stuff the commit message talks about
with other changes *which are not mentioned in the commit message* and
which are *unrelated to the bug in question*.
Two changes get two patches, it's pretty simple. And, commit messages
must tell the whole truth and nothing but the truth. I really hate
having to be this careful in reviewing your patches.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2011-10-31 2:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 1:20 [PATCH v2] drm/i915: Fix recursive calls to unmap Ben Widawsky
2011-10-31 1:36 ` Keith Packard
2011-10-31 1:52 ` Ben Widawsky
2011-10-31 2:35 ` Keith Packard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunbosx3n34.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.