From: Keith Packard <keithp@keithp.com>
To: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI
Date: Tue, 20 Sep 2011 09:55:08 -0700 [thread overview]
Message-ID: <yund3evf91v.fsf@aiko.keithp.com> (raw)
In-Reply-To: <201109201738.37448.simon.farnsworth@onelan.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1248 bytes --]
On Tue, 20 Sep 2011 17:38:37 +0100, Simon Farnsworth <simon.farnsworth@onelan.co.uk> wrote:
> This interacts badly with the need I've found to call this function every time
> a hotplug interrupt comes through (explained below) - I'm not sure how to
> track back from the encoder (which gets the callback) to the SDVO device
> number.
You might store the desired hotplug bits in the intel_sdvo structure,
and then use that in the enable function. The enable function should be
able to just call SET_ACTIVE_HOT_PLUG with the desired value instead of
making the four calls that it does now, right?
> If I don't call intel_sdvo_enable_hotplug at this point, I only get the one
> hotplug interrupt; it appears that the SDVO devices I have send their
> interrupt, then expect you to re-enable HPD interrupts before they will send
> another interrupt.
ok, sounds good.
> I'm not sure how best to handle this; my gut feeling is that there's no real
> harm enabling HPD interrupts on all ports that support it, even though I'm
> only processing HPD interrupts from DVI and HDMI ports. If you have better
> ideas, I'm happy to try them.
It probably is harmless, just seems a bit messy.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-09-20 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 14:17 [PATCH] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI Simon Farnsworth
2011-09-20 14:18 ` Simon Farnsworth
2011-09-20 16:27 ` Keith Packard
2011-09-20 16:38 ` Simon Farnsworth
2011-09-20 16:55 ` Keith Packard [this message]
2011-09-20 16:57 ` Simon Farnsworth
2011-09-20 17:05 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yund3evf91v.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=simon.farnsworth@onelan.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.