All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Reset GMBUS controller after NAK
Date: Wed, 30 Mar 2011 10:56:39 -0700	[thread overview]
Message-ID: <yunhbak7aqw.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1301506964-27616-1-git-send-email-chris@chris-wilson.co.uk>


[-- Attachment #1.1: Type: text/plain, Size: 690 bytes --]

On Wed, 30 Mar 2011 18:42:44 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Once a NAK has been asserted by the slave, we need to reset the GMBUS
> controller in order to continue. This is done by asserting the Software
> Clear Interrupt bit and then clearing it again to restore operations.
> 
> If we don't clear the NAK, then all future GMBUS xfers will fail,
> including DDC probes and EDID retrieval.
> 
> v2: Add some comments as suggested by Keith Packard.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=35781
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Keith Packard <keithp@keithp.com>

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-03-30 17:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30 16:07 [PATCH] drm/i915: Reset GMBUS controller after NAK Chris Wilson
2011-03-30 16:48 ` Keith Packard
2011-03-30 16:59   ` Chris Wilson
2011-03-30 17:22     ` Keith Packard
2011-03-30 17:42       ` Chris Wilson
2011-03-30 17:56         ` Keith Packard [this message]
2011-03-30 20:05 ` Jesse Barnes
2011-03-31 15:16   ` Steven Newbury
2011-03-31 15:20     ` Chris Wilson
2011-03-31 15:33       ` Steven Newbury
2011-04-02 21:50         ` Steven Newbury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yunhbak7aqw.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.