All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: intel-gfx@lists.freedesktop.org
Cc: Dave Airlie <airlied@redhat.com>, Ben Widawsky <ben@bwidawsk.net>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] drm/i915: Ironlake GPU with VT-d fix
Date: Thu, 22 Sep 2011 21:50:49 -0700	[thread overview]
Message-ID: <yunipoj276e.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1316736712-5887-1-git-send-email-ben@bwidawsk.net>


[-- Attachment #1.1: Type: text/plain, Size: 894 bytes --]

On Thu, 22 Sep 2011 17:11:52 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:

> It requires an additional IOMMU patch.

Can we collect those two patches into one sequence?

> +	if ((gpu_devid == PCI_DEVICE_ID_INTEL_IRONLAKE_M_HB ||
> +	     gpu_devid == PCI_DEVICE_ID_INTEL_IRONLAKE_M_IG) &&
> +	     intel_private.base.needs_dmar)
> +		intel_private.base.do_idle_maps = 1;
> +

I'd like to make this conditional on whether IOMMU is actually in use;
needs_dmar is based solely on whether the DMA_API is compiled into the
kernel and the GTT gen is > 2.

> -	if (lists_empty)
> +	if (lists_empty && !!dev_priv->mm.gtt->do_idle_maps)
>  		return 0;

Is it necessary to change the semantic of this function in cases which
aren't related to GTT remapping? Seems like you're imposing a fairly
high cost on operations which don't actually need it.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-09-23  4:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23  0:11 [PATCH] drm/i915: Ironlake GPU with VT-d fix Ben Widawsky
2011-09-23  4:50 ` Keith Packard [this message]
2011-09-23  5:09   ` Ben Widawsky
2011-09-23  7:37     ` Chris Wilson
2011-09-23 15:38       ` Ben Widawsky
2011-09-23 19:03         ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yunipoj276e.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=airlied@redhat.com \
    --cc=ben@bwidawsk.net \
    --cc=dwmw2@infradead.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.