From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: force wake reference counting (another try)
Date: Tue, 12 Apr 2011 10:41:47 -0700 [thread overview]
Message-ID: <yunipujpdt0.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1bdc18$k6n2j0@fmsmga002.fm.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 807 bytes --]
On Tue, 12 Apr 2011 18:21:23 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Agreed. I had been working under the assumption that dev->struct_mutex was
> the sufficient lock. This may be entirely due to the false premise that we
> only needed i915_gt_read() for the ring registers. I still haven't looked
> through just what registers are impacted.
Seems like we should start using a spinlock and wake lock around all
register accesses, then figure out which registers are not within the GT
power well and split those off to a separate macro which avoids both. If
we finally discover that all wake-lock requiring registers are now
obviously covered by the struct mutex, we could then consider removing
the spinlock.
Make it work, then make it fast.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-04-12 17:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 1:01 force wake reference counting (another try) Ben Widawsky
2011-04-12 1:01 ` [PATCH 1/4] drm/i915: proper use of forcewake Ben Widawsky
2011-04-12 1:01 ` [PATCH 2/4] drm/i915: refcounts for forcewake Ben Widawsky
2011-04-12 1:01 ` [PATCH 3/4] drm/i915: userspace interface to the forcewake refcount Ben Widawsky
2011-04-12 1:01 ` [PATCH 4/4] drm/i915: fewer warning patch (temporary) Ben Widawsky
2011-04-12 8:02 ` force wake reference counting (another try) Chris Wilson
2011-04-12 16:30 ` Ben Widawsky
2011-04-12 16:56 ` Keith Packard
2011-04-12 17:21 ` Chris Wilson
2011-04-12 17:41 ` Keith Packard [this message]
2011-04-13 1:31 ` Ben Widawsky
2011-04-13 5:31 ` Keith Packard
2011-04-13 5:52 ` Chris Wilson
2011-04-13 6:35 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunipujpdt0.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.