From: Keith Packard <keithp@keithp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Daniel Vetter <daniel@ffwll.ch>, Dave Airlie <airlied@redhat.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing
Date: Wed, 27 Jul 2011 02:21:24 -0700 [thread overview]
Message-ID: <yunk4b43wq3.fsf@aiko.keithp.com> (raw)
In-Reply-To: <20110726121225.3ae7acce@jbarnes-desktop>
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
On Tue, 26 Jul 2011 12:12:25 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> I'd like to amend my reviewed by and say the lock shouldn't be held
> around the call to the drm helper function. It queues some work that
> also takes the mode config lock, which will break. So you can drop it
> before that... Previously I had only checked our internal driver
> callbacks but missed that the lock was held across the helper too.
So the work may get executed immediately rather than being run later at
some point?
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Keith Packard <keithp@keithp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: dri-devel@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Hold struct_mutex during hotplug processing
Date: Wed, 27 Jul 2011 02:21:24 -0700 [thread overview]
Message-ID: <yunk4b43wq3.fsf@aiko.keithp.com> (raw)
In-Reply-To: <20110726121225.3ae7acce@jbarnes-desktop>
[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]
On Tue, 26 Jul 2011 12:12:25 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> I'd like to amend my reviewed by and say the lock shouldn't be held
> around the call to the drm helper function. It queues some work that
> also takes the mode config lock, which will break. So you can drop it
> before that... Previously I had only checked our internal driver
> callbacks but missed that the lock was held across the helper too.
So the work may get executed immediately rather than being run later at
some point?
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-07-27 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 17:10 [PATCH] drm/i915: Hold struct_mutex during hotplug processing Keith Packard
2011-07-25 17:37 ` [Intel-gfx] " Jesse Barnes
2011-07-25 17:40 ` Andrew Lutomirski
2011-07-25 17:55 ` Keith Packard
2011-07-26 2:52 ` Andrew Lutomirski
2011-07-26 2:52 ` Andrew Lutomirski
2011-07-26 5:54 ` Keith Packard
2011-07-26 5:54 ` Keith Packard
2011-07-26 12:35 ` [Intel-gfx] " Andrew Lutomirski
2011-07-26 12:35 ` Andrew Lutomirski
2011-07-26 7:24 ` Daniel Vetter
2011-07-26 15:23 ` Keith Packard
2011-07-26 19:12 ` Jesse Barnes
2011-07-26 19:12 ` Jesse Barnes
2011-07-27 9:21 ` Keith Packard [this message]
2011-07-27 9:21 ` Keith Packard
2011-07-27 16:03 ` [Intel-gfx] " Jesse Barnes
2011-07-28 22:50 ` Keith Packard
2011-07-29 10:25 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunk4b43wq3.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.