From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: stable@kernel.org
Subject: Re: [PATCH fixes] drm/i915: Fix unfenced alignment on pre-G33 hardware
Date: Mon, 06 Jun 2011 09:03:30 -0700 [thread overview]
Message-ID: <yunlixf0wx9.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1307369924-3601-1-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 901 bytes --]
On Mon, 6 Jun 2011 15:18:44 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> case I915_PARAM_HAS_RELAXED_FENCING:
> - value = 1;
> + value = 2;
This looks like a change in ABI to me. I think this means you want a new
ioctl so that applications using the existing HAS_RELAXED_FENCING ioctl
and expecting a boolean will continue to work.
> uint32_t
> -i915_gem_get_unfenced_gtt_alignment(struct drm_i915_gem_object *obj);
> +i915_gem_get_unfenced_gtt_alignment(struct drm_i915_gem_object *obj,
> + int tiling_mode);
...
> - i915_gem_get_unfenced_gtt_alignment(obj);
> + i915_gem_get_unfenced_gtt_alignment(obj,
> + args->tiling_mode);
This combination looks like a simple bug fix -- not using the new tiling
mode when computing the required alignment. Can you separate out this
From the power-of-two change?
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-06-06 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 14:18 [PATCH fixes] drm/i915: Fix unfenced alignment on pre-G33 hardware Chris Wilson
2011-06-06 16:03 ` Keith Packard [this message]
2011-06-06 17:50 ` [Intel-gfx] " Chris Wilson
2011-06-06 18:09 ` Keith Packard
2011-06-06 20:56 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunlixf0wx9.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.