All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCHv5] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI
Date: Wed, 21 Sep 2011 07:58:51 -0700	[thread overview]
Message-ID: <yunmxdyeyc4.fsf@aiko.keithp.com> (raw)
In-Reply-To: <201109211008.14518.simon.farnsworth@onelan.co.uk>


[-- Attachment #1.1: Type: text/plain, Size: 910 bytes --]

On Wed, 21 Sep 2011 10:08:13 +0100, Simon Farnsworth <simon.farnsworth@onelan.co.uk> wrote:

> I'm clearing the bits (&= not |=). I could respin setting it to 0, but that 
> takes me even further from the old (commented out) code, and I'd really want 
> someone to check SDVO specs before doing that.

What I see the code doing is asking whether devices 0 and 1 *could*
support hotplug and then unconditionally setting the devices for which
we *want* hotplug to that.

I think you should set the list of devices requesting hotplug to be the
intersection of the set of devices which *could* do hotplug and the
set of devices for which we *want* hotplug.

That seems like it would be achieved by just clearing the set of devices
that we will request hotplug for and then checking which ones are
supported and incrementally adding those to the hotplug_active set.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-09-21 14:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-20 17:31 [PATCHv5] drm/i915: Enable SDVO hotplug interrupts for HDMI and DVI Simon Farnsworth
2011-09-20 19:43 ` Keith Packard
2011-09-21  9:08   ` Simon Farnsworth
2011-09-21 14:58     ` Keith Packard [this message]
2011-09-21 15:18       ` Simon Farnsworth
2011-09-21 15:47         ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yunmxdyeyc4.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=simon.farnsworth@onelan.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.