From: Keith Packard <keithp@keithp.com>
To: Adam Jackson <ajax@redhat.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/pch: Fix integer math bugs in panel fitting
Date: Wed, 13 Jul 2011 13:47:40 -0700 [thread overview]
Message-ID: <yunoc0x9ac3.fsf@aiko.keithp.com> (raw)
In-Reply-To: <1310589152-31945-1-git-send-email-ajax@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 329 bytes --]
On Wed, 13 Jul 2011 16:32:32 -0400, Adam Jackson <ajax@redhat.com> wrote:
> + if (width & 1)
> + width++;
> + if (height & 1)
> + height++;
You'll want to stick a comment in here describing why this is
here. Otherwise, someone will just break it in the future.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-07-13 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 20:32 [PATCH] drm/i915/pch: Fix integer math bugs in panel fitting Adam Jackson
2011-07-13 20:47 ` Keith Packard [this message]
2011-07-20 7:15 ` Christopher James Halse Rogers
2011-07-21 11:18 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunoc0x9ac3.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=ajax@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.