From: "Måns Rullgård" <mans@mansr.com>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Cc: Sean Young <sean@mess.org>,
linux-media <linux-media@vger.kernel.org>,
Mason <slash.tmp@free.fr>
Subject: Re: [PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder
Date: Tue, 26 Sep 2017 15:49:27 +0100 [thread overview]
Message-ID: <yw1xing5ecqw.fsf@mansr.com> (raw)
In-Reply-To: <ee434b81-3406-7ea0-3a54-b5dc1d6720c9@sigmadesigns.com> (Marc Gonzalez's message of "Tue, 26 Sep 2017 16:14:21 +0200")
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> On 26/09/2017 15:02, Måns Rullgård wrote:
>
>> I could continue nit-picking, but I think this is good enough.
>> Thanks for being patient.
>>
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>
> Smirk.
>
> If you feel like making a final round of changes on top of this patch,
> then go for it. It's your code, after all.
>
> (Too bad there is no devm variant of clk_prepare_enable.)
>
> Does it make sense to submit a keymap for the Sigma remote control
> used with Vantage boards? And define that as the default keymap?
Maybe. The real product I have with a tango3 chip uses a remote control
that is quite similar the Sigma one. Having something that works out of
the box with the dev board is also nice.
--
Måns Rullgård
next prev parent reply other threads:[~2017-09-26 14:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 12:02 [PATCH v4 1/2] media: dt: bindings: Add binding for tango HW IR decoder Marc Gonzalez
2017-09-25 12:14 ` [PATCH v4 2/2] media: rc: Add driver " Marc Gonzalez
2017-09-25 14:08 ` Måns Rullgård
2017-09-25 15:00 ` Marc Gonzalez
2017-09-25 16:34 ` Måns Rullgård
2017-09-25 16:07 ` [PATCH v5 " Marc Gonzalez
2017-09-25 16:45 ` Måns Rullgård
2017-09-26 8:51 ` [PATCH v6 " Marc Gonzalez
2017-09-26 13:02 ` Måns Rullgård
2017-09-26 14:14 ` Marc Gonzalez
2017-09-26 14:49 ` Måns Rullgård [this message]
2017-10-04 16:00 ` Marc Gonzalez
2017-10-04 21:18 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xing5ecqw.fsf@mansr.com \
--to=mans@mansr.com \
--cc=linux-media@vger.kernel.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=sean@mess.org \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.