From: "Måns Rullgård" <mans@mansr.com>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Cc: Sean Young <sean@mess.org>,
linux-media <linux-media@vger.kernel.org>,
Mason <slash.tmp@free.fr>
Subject: Re: [PATCH v5 2/2] media: rc: Add driver for tango HW IR decoder
Date: Mon, 25 Sep 2017 17:45:00 +0100 [thread overview]
Message-ID: <yw1xr2uuenhv.fsf@mansr.com> (raw)
In-Reply-To: <893874ee-a6e0-e4be-5b4f-a49e60197e92@free.fr> (Marc Gonzalez's message of "Mon, 25 Sep 2017 18:07:14 +0200")
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> * Delete two writes clearing interrupts in probe (cleared is reset value)
Noooooo. You can't know what state the hardware is in when this code
runs. Drivers should *always* fully initialise the hardware to a known
state. It is especially important to clear any pending interrupts since
otherwise they'll fire the moment the irq is unmasked and can cause all
sorts of mayhem.
--
Måns Rullgård
next prev parent reply other threads:[~2017-09-25 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 12:02 [PATCH v4 1/2] media: dt: bindings: Add binding for tango HW IR decoder Marc Gonzalez
2017-09-25 12:14 ` [PATCH v4 2/2] media: rc: Add driver " Marc Gonzalez
2017-09-25 14:08 ` Måns Rullgård
2017-09-25 15:00 ` Marc Gonzalez
2017-09-25 16:34 ` Måns Rullgård
2017-09-25 16:07 ` [PATCH v5 " Marc Gonzalez
2017-09-25 16:45 ` Måns Rullgård [this message]
2017-09-26 8:51 ` [PATCH v6 " Marc Gonzalez
2017-09-26 13:02 ` Måns Rullgård
2017-09-26 14:14 ` Marc Gonzalez
2017-09-26 14:49 ` Måns Rullgård
2017-10-04 16:00 ` Marc Gonzalez
2017-10-04 21:18 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xr2uuenhv.fsf@mansr.com \
--to=mans@mansr.com \
--cc=linux-media@vger.kernel.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=sean@mess.org \
--cc=slash.tmp@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.