Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Chaithrika U S" <chaithrika@ti.com>
To: 'Takashi Iwai' <tiwai@suse.de>
Cc: khilman@deeprootsystems.com, alsa-devel@alsa-project.org,
	broonie@opensource.wolfsonmicro.com,
	davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH] ASoC: DaVinci: Update suspend/resume support	for McASP driver
Date: Thu, 3 Dec 2009 17:58:08 +0530	[thread overview]
Message-ID: <000301ca7414$12280120$36780360$@com> (raw)
In-Reply-To: <s5hskbtybeg.wl%tiwai@suse.de>

On Wed, Dec 02, 2009 at 14:56:31, Takashi Iwai wrote:
> At Wed,  2 Dec 2009 12:39:00 +0530,
> Chaithrika U S wrote:
> > 
> > diff --git a/sound/soc/davinci/davinci-pcm.c b/sound/soc/davinci/davinci-pcm.c
> > index ad4d7f4..80c7fdf 100644
> > --- a/sound/soc/davinci/davinci-pcm.c
> > +++ b/sound/soc/davinci/davinci-pcm.c
> > @@ -49,7 +49,7 @@ static void print_buf_info(int slot, char *name)
> >  static struct snd_pcm_hardware pcm_hardware_playback = {
> >  	.info = (SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
> >  		 SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |
> > -		 SNDRV_PCM_INFO_PAUSE),
> > +		 SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME),
> 
> Note that unless your driver supports the "full" resume,
> SNDRV_PCM_INFO_RESUME shouldn't be set.  Here, the "full" resume means
> that the hardware gets back to a completely sane state and the PCM
> streams are resumed without extra PCM prepare call at PM resume.
> If the PCM (or whatever) needs another re-initialization (like in many
> cases), don't set this flag.
> 
> Just to be sure...
> 
> 
> Takashi
> 

PCM prepare call is not needed in this case. Testing was done with audio
loopback and after a suspend/resume cycle the audio output was proper. Hope
my understanding is correct. Is this test sufficient to prove that driver
supports full resume?

Regards, 
Chaithrika

  reply	other threads:[~2009-12-03 12:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02  7:09 [PATCH] ASoC: DaVinci: Update suspend/resume support for McASP driver Chaithrika U S
2009-12-02  9:26 ` Takashi Iwai
2009-12-03 12:28   ` Chaithrika U S [this message]
2009-12-03 13:13     ` Takashi Iwai
2009-12-03 13:27       ` Mark Brown
     [not found]         ` <20091203132717.GA412-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-12-03 13:34           ` [alsa-devel] " Chaithrika U S
2009-12-03 13:00 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000301ca7414$12280120$36780360$@com' \
    --to=chaithrika@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=khilman@deeprootsystems.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox