Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Chaithrika U S <chaithrika@ti.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH] ASoC: DaVinci: Update suspend/resume support for McASP driver
Date: Thu, 03 Dec 2009 16:00:19 +0300	[thread overview]
Message-ID: <4B17B663.70206@ru.mvista.com> (raw)
In-Reply-To: <1259737740-27324-1-git-send-email-chaithrika@ti.com>

Hello.

Chaithrika U S wrote:

> Add clock enable and disable calls to resume and suspend respectively.
> Also add a member to the audio device data structure which tracks the clock
> status.

> Tested on DA850/OMAP-L138 EVM. For the purpose of testing, the patches[1] which 
> add suspend-to-RAM support to DA850/OMAP-L138 SoC were applied.

> [1] http://linux.davincidsp.com/pipermail/davinci-linux-open-source/
> 2009-November/016958.html

> Signed-off-by: Chaithrika U S <chaithrika@ti.com>
> ---

[...]

> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 0a302e1..0d263f1 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -767,14 +767,27 @@ static int davinci_mcasp_trigger(struct snd_pcm_substream *substream,
>  	int ret = 0;
>  
>  	switch (cmd) {
> -	case SNDRV_PCM_TRIGGER_START:
>  	case SNDRV_PCM_TRIGGER_RESUME:
> +		if (!dev->clk_active) {
> +			clk_enable(dev->clk);
> +			dev->clk_active = 1;
> +		}

   You should add a comment in the cases where *break* is ommitted 
deliberately (if it indeed is), like:

		/* FALL THRU */

> +
> +	case SNDRV_PCM_TRIGGER_START:
>  	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>  		davinci_mcasp_start(dev, substream->stream);
>  		break;
>  

WBR, Sergei

      parent reply	other threads:[~2009-12-03 12:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02  7:09 [PATCH] ASoC: DaVinci: Update suspend/resume support for McASP driver Chaithrika U S
2009-12-02  9:26 ` Takashi Iwai
2009-12-03 12:28   ` Chaithrika U S
2009-12-03 13:13     ` Takashi Iwai
2009-12-03 13:27       ` Mark Brown
     [not found]         ` <20091203132717.GA412-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2009-12-03 13:34           ` [alsa-devel] " Chaithrika U S
2009-12-03 13:00 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B17B663.70206@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=chaithrika@ti.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox