From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH] ASoC: SOF: ipc4-topology: Fix error code in sof_ipc4_volume_put()
Date: Thu, 16 Jun 2022 09:30:14 +0300 [thread overview]
Message-ID: <01641154-8cf3-ef29-3bc2-c3c1b31b877c@linux.intel.com> (raw)
In-Reply-To: <YqqyDU5BhOzpRjco@kili>
On 16/06/2022 07:31, Dan Carpenter wrote:
> The sof_ipc4_volume_put() function returns type bool so returning
> -ENOENT means returning true. Return false instead.
Good catch,
Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> Fixes: 955e84fc0b6d ("ASoC: SOF: ipc4-topology: Add control IO ops")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> sound/soc/sof/ipc4-control.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/ipc4-control.c b/sound/soc/sof/ipc4-control.c
> index 95ee121dd3cf..0d5a578c3496 100644
> --- a/sound/soc/sof/ipc4-control.c
> +++ b/sound/soc/sof/ipc4-control.c
> @@ -142,7 +142,7 @@ static bool sof_ipc4_volume_put(struct snd_sof_control *scontrol,
>
> if (!widget_found) {
> dev_err(scomp->dev, "Failed to find widget for kcontrol %s\n", scontrol->name);
> - return -ENOENT;
> + return false;
> }
>
> ret = sof_ipc4_set_volume_data(sdev, swidget, scontrol);
--
Péter
next prev parent reply other threads:[~2022-06-16 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 4:31 [PATCH] ASoC: SOF: ipc4-topology: Fix error code in sof_ipc4_volume_put() Dan Carpenter
2022-06-16 6:30 ` Péter Ujfalusi [this message]
2022-06-16 11:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01641154-8cf3-ef29-3bc2-c3c1b31b877c@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox