From: "chaithrika" <chaithrika@ti.com>
To: 'Denys Dmytriyenko' <denis@denix.org>
Cc: alsa-devel@alsa-project.org,
'Pavel Kiryukhin' <pkiryukhin@ru.mvista.com>,
davinci-linux-open-source@linux.davincidsp.com,
'Naresh Medisetty' <naresh@ti.com>
Subject: Re: [PATCH v4 3/4] ARM: DaVinci: ASoC: Add mcasp support for DM646x
Date: Mon, 15 Jun 2009 14:40:24 +0530 [thread overview]
Message-ID: <01ac01c9ed99$1df78630$59e69290$@com> (raw)
In-Reply-To: <20090612013107.GA19074@denix.org>
On Fri, Jun 12, 2009 at 07:01:07, Denys Dmytriyenko wrote:
> Chaithrika,
>
> On Fri, Jun 05, 2009 at 06:28:40AM -0400, Chaithrika U S wrote:
> > Adds driver support for the two instances of McASP on TI's DM646x.
>
> In patch #3 you removed struct evm_snd_platform_data:
>
> > -struct evm_snd_platform_data {
> > - int tx_dma_ch;
> > - int rx_dma_ch;
> > -};
>
> That structure is still used in sound/soc/davinci/davinci-evm.c, until you
fix
> it by patch #4:
>
> > -static struct evm_snd_platform_data dm335evm_snd_data = {
> > - .tx_dma_ch = DAVINCI_DMA_ASP1_TX,
> > - .rx_dma_ch = DAVINCI_DMA_ASP1_RX,
>
> That would break git-bisect...
Denys,
These patches have been merged. In the future, I will try to ensure that
there
will not be a break when a patch series is submitted.
>
> --
> Denys
>
Regards,
Chaithrika
prev parent reply other threads:[~2009-06-15 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 10:28 [PATCH v4 3/4] ARM: DaVinci: ASoC: Add mcasp support for DM646x Chaithrika U S
[not found] ` <1244197720-31006-1-git-send-email-chaithrika-l0cyMroinI0@public.gmane.org>
2009-06-12 1:31 ` Denys Dmytriyenko
2009-06-15 9:10 ` chaithrika [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01ac01c9ed99$1df78630$59e69290$@com' \
--to=chaithrika@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=denis@denix.org \
--cc=naresh@ti.com \
--cc=pkiryukhin@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox