From: Denys Dmytriyenko <denis-hqcsM7nSK1nYtjvyW6yDsg@public.gmane.org>
To: Chaithrika U S <chaithrika-l0cyMroinI0@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
Pavel Kiryukhin
<pkiryukhin-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
Naresh Medisetty <naresh-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH v4 3/4] ARM: DaVinci: ASoC: Add mcasp support for DM646x
Date: Thu, 11 Jun 2009 21:31:07 -0400 [thread overview]
Message-ID: <20090612013107.GA19074@denix.org> (raw)
In-Reply-To: <1244197720-31006-1-git-send-email-chaithrika-l0cyMroinI0@public.gmane.org>
Chaithrika,
On Fri, Jun 05, 2009 at 06:28:40AM -0400, Chaithrika U S wrote:
> Adds driver support for the two instances of McASP on TI's DM646x.
In patch #3 you removed struct evm_snd_platform_data:
> -struct evm_snd_platform_data {
> - int tx_dma_ch;
> - int rx_dma_ch;
> -};
That structure is still used in sound/soc/davinci/davinci-evm.c, until you fix
it by patch #4:
> -static struct evm_snd_platform_data dm335evm_snd_data = {
> - .tx_dma_ch = DAVINCI_DMA_ASP1_TX,
> - .rx_dma_ch = DAVINCI_DMA_ASP1_RX,
That would break git-bisect...
--
Denys
next prev parent reply other threads:[~2009-06-12 1:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 10:28 [PATCH v4 3/4] ARM: DaVinci: ASoC: Add mcasp support for DM646x Chaithrika U S
[not found] ` <1244197720-31006-1-git-send-email-chaithrika-l0cyMroinI0@public.gmane.org>
2009-06-12 1:31 ` Denys Dmytriyenko [this message]
2009-06-15 9:10 ` chaithrika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090612013107.GA19074@denix.org \
--to=denis-hqcsm7nsk1nytjvyw6ydsg@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=chaithrika-l0cyMroinI0@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=naresh-l0cyMroinI0@public.gmane.org \
--cc=pkiryukhin-hkdhdckH98+B+jHODAdFcQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox