[PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

[PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

[Hans de Goede]

Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
mono-speaker. Otherwise it works fine with the defaults.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 7456566c5648..718f022b3aa0 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -486,6 +486,16 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
 		},
 		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
 	},
+	{	/* Connect Tablet 9 */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Connect"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Tablet 9"),
+		},
+		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+					BYT_RT5640_MONO_SPEAKER |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
+	},
 	{
 		.matches = {
 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
-- 
2.17.1

Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 237 bytes --]

On Sun, Jul 01, 2018 at 11:30:23AM +0200, Hans de Goede wrote:
> Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
> mono-speaker. Otherwise it works fine with the defaults.

Did this get rolled up into some other series?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

[Hans de Goede]

Hi,

On 18-07-18 13:25, Mark Brown wrote:
> On Sun, Jul 01, 2018 at 11:30:23AM +0200, Hans de Goede wrote:
>> Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
>> mono-speaker. Otherwise it works fine with the defaults.
> 
> Did this get rolled up into some other series?

No this patch is still pending / waiting for you to merge it.

Regards,

Hans

Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]

On Wed, Jul 18, 2018 at 02:54:32PM +0200, Hans de Goede wrote:
> On 18-07-18 13:25, Mark Brown wrote:
> > On Sun, Jul 01, 2018 at 11:30:23AM +0200, Hans de Goede wrote:
> > > Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
> > > mono-speaker. Otherwise it works fine with the defaults.

> > Did this get rolled up into some other series?

> No this patch is still pending / waiting for you to merge it.

I'm still waiting for Pierre to review it so...

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

[Pierre-Louis Bossart]

On 07/01/2018 04:30 AM, Hans de Goede wrote:
> Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
> mono-speaker. Otherwise it works fine with the defaults.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Sorry about the delay, I missed this patch.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 7456566c5648..718f022b3aa0 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -486,6 +486,16 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   		},
>   		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
>   	},
> +	{	/* Connect Tablet 9 */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Connect"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Tablet 9"),
> +		},
> +		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> +					BYT_RT5640_MONO_SPEAKER |
> +					BYT_RT5640_SSP0_AIF1 |
> +					BYT_RT5640_MCLK_EN),
> +	},
>   	{
>   		.matches = {
>   			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),

Applied "ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet" to the asoc tree

[Mark Brown]

The patch

   ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 9ee6f8a8cbbd203fb0a844f937007a9525422697 Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat.com>
Date: Sun, 1 Jul 2018 11:30:23 +0200
Subject: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet
 9" tablet

Add a quirk for the "Connect Tablet 9" tablet, this tablet has a
mono-speaker. Otherwise it works fine with the defaults.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 657910a08261..d32844f94d74 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -486,6 +486,16 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
 		},
 		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
 	},
+	{	/* Connect Tablet 9 */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Connect"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Tablet 9"),
+		},
+		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+					BYT_RT5640_MONO_SPEAKER |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
+	},
 	{
 		.matches = {
 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
-- 
2.18.0