From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Ammar Faizi" <ammarfaizi2@gnuweeb.org>,
"Mark Brown" <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Keyon Jie <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Rander Wang <rander.wang@intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM
Date: Thu, 24 Feb 2022 12:05:30 -0600 [thread overview]
Message-ID: <04e79b9c-ccb1-119a-c2e2-34c8ca336215@linux.intel.com> (raw)
In-Reply-To: <cfe9e583-e20a-f1d6-2a81-2538ca3ca054@linux.intel.com>
>> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>>
>> Do not call snd_dma_free_pages() when snd_dma_alloc_pages() returns
>> -ENOMEM because it leads to a NULL pointer dereference bug.
>
> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Thanks for this patch. looks good and tested by our CI, so
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
next prev parent reply other threads:[~2022-02-24 18:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 14:51 [PATCH] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM Ammar Faizi
2022-02-24 16:53 ` Péter Ujfalusi
2022-02-24 17:55 ` Ammar Faizi
2022-02-24 18:05 ` Pierre-Louis Bossart [this message]
2022-02-24 17:26 ` Mark Brown
2022-02-24 17:56 ` Ammar Faizi
2022-02-24 18:08 ` [PATCH v2] " Ammar Faizi
2022-02-24 18:14 ` Mark Brown
2022-02-24 18:28 ` [PATCH v3] " Ammar Faizi
2022-02-24 18:58 ` [PATCH v4] " Ammar Faizi
2022-02-24 22:58 ` Mark Brown
2022-02-24 22:58 ` [PATCH v3] " Mark Brown
2022-02-24 22:58 ` [PATCH v2] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04e79b9c-ccb1-119a-c2e2-34c8ca336215@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox