From: Lee Revell <rlrevell@joe-job.com>
To: alsa-devel <alsa-devel@lists.sourceforge.net>
Cc: James Courtier-Dutton <James@superbug.co.uk>
Subject: Re: [PATCH] emu10k1: fix P16V breakage for non Audigy2 cards
Date: Wed, 16 Mar 2005 00:27:12 -0500 [thread overview]
Message-ID: <1110950832.19984.13.camel@mindpipe> (raw)
In-Reply-To: <1110950511.19984.9.camel@mindpipe>
On Wed, 2005-03-16 at 00:21 -0500, Lee Revell wrote:
> The P16V patch unconditionally checks the IPR2 register in the interrupt
> handler resulting in infinite loop and system lockup on any non Audigy2
> cards. I really hate checking emu->is_audigy and emu->revision in a
> fast path like the IRQ handler but I don't see another way.
>
> Also, don't bother allocating/freeing the DMA buffer for P16V unless
> it's really present.
Oh, one more thing: this patch restores the "unhandled interrupt"
printk() that was commented out by the P16V patch. I am sure this was
useful for development but seems like a bad idea for production.
James, were you still getting unhandled interrupts with the version of
the patch that was merged?
Lee
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-03-16 5:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 5:21 [PATCH] emu10k1: fix P16V breakage for non Audigy2 cards Lee Revell
2005-03-16 5:27 ` Lee Revell [this message]
2005-03-16 21:28 ` James Courtier-Dutton
2005-03-17 15:53 ` Lee Revell
2005-03-17 15:58 ` Takashi Iwai
2005-03-17 16:00 ` Lee Revell
2005-03-17 16:20 ` Lee Revell
2005-03-17 16:41 ` Takashi Iwai
2005-03-17 16:48 ` Lee Revell
2005-03-18 19:52 ` James Courtier-Dutton
2005-03-18 19:54 ` Lee Revell
2005-03-18 19:56 ` Lee Revell
2005-03-17 14:11 ` [PATCH] emu10k1: fix misc oopses Thierry Vignaud
2005-03-17 15:02 ` Lee Revell
2005-03-17 16:01 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110950832.19984.13.camel@mindpipe \
--to=rlrevell@joe-job.com \
--cc=James@superbug.co.uk \
--cc=alsa-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox