Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Thierry Vignaud <tvignaud@mandrakesoft.com>
Cc: Lee Revell <rlrevell@joe-job.com>,
	alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH] emu10k1: fix misc oopses
Date: Thu, 17 Mar 2005 17:01:28 +0100	[thread overview]
Message-ID: <s5hfyyu1ctj.wl@alsa2.suse.de> (raw)
In-Reply-To: <m2u0naqs54.fsf@vador.mandrakesoft.com>

At Thu, 17 Mar 2005 15:11:19 +0100,
Thierry Vignaud wrote:
> 
> [1  <text/plain (7bit)>]
> Lee Revell <rlrevell@joe-job.com> writes:
> 
> > The P16V patch unconditionally checks the IPR2 register in the
> > interrupt handler resulting in infinite loop and system lockup on
> > any non Audigy2 cards.  I really hate checking emu->is_audigy and
> > emu->revision in a fast path like the IRQ handler but I don't see
> > another way.
> > 
> > Also, don't bother allocating/freeing the DMA buffer for P16V unless
> > it's really present.
> > 
> > This is a critical fix and should trigger an immediate rc2 release
> > IMO.  Currently any emu10k1 users other than Audigy 2 will lock up
> > hard as soon as they play any sound.
> > 
> > Signed-Off-By: Lee Revell <rlrevell@joe-job.com>
> 
> fix more oopses:
> 
> Signed-Off-By: Arnaud Patard <apatard@mandrakesoft.com>

Thanks.  Applied now.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

      parent reply	other threads:[~2005-03-17 16:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-16  5:21 [PATCH] emu10k1: fix P16V breakage for non Audigy2 cards Lee Revell
2005-03-16  5:27 ` Lee Revell
2005-03-16 21:28   ` James Courtier-Dutton
2005-03-17 15:53     ` Lee Revell
2005-03-17 15:58       ` Takashi Iwai
2005-03-17 16:00         ` Lee Revell
2005-03-17 16:20         ` Lee Revell
2005-03-17 16:41           ` Takashi Iwai
2005-03-17 16:48             ` Lee Revell
2005-03-18 19:52       ` James Courtier-Dutton
2005-03-18 19:54         ` Lee Revell
2005-03-18 19:56         ` Lee Revell
2005-03-17 14:11 ` [PATCH] emu10k1: fix misc oopses Thierry Vignaud
2005-03-17 15:02   ` Lee Revell
2005-03-17 16:01   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfyyu1ctj.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=rlrevell@joe-job.com \
    --cc=tvignaud@mandrakesoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox