Re: DMA mapping (was Re: [PATCH] cciss 2.6; replaces DMA masks with kernel defines)

Re: DMA mapping (was Re: [PATCH] cciss 2.6; replaces DMA masks with kernel defines)

[Lee Revell]

On Fri, 2005-06-10 at 22:45 +0200, Arjan van de Ven wrote:
> On Fri, 2005-06-10 at 16:39 -0400, Lee Revell wrote:
> > On Fri, 2005-06-10 at 12:55 -0400, Jeff Garzik wrote:
> > > mike.miller@hp.com wrote:
> > > > This patch removes our homegrown DMA masks and uses the ones defined in
> > > > the kernel instead.
> > > > Thanks to Jens Axboe for the code. Please consider this for inclusion.
> > > > 
> > > > Signed-off-by: Mike Miller <mike.miller@hp.com>
> > > 
> > > You need to add '#include <linux/dma-mapping.h>'
> > > 
> > 
> > Why doesn't this file define 29, 30, 31 bit DMA masks, required by many
> > devices?  I know of at least 2 soundcards that need a 29 bit DMA mask.
> 
> your mail unfortunately was not in diff -u form ;)
> I'm pretty sure that such constants are welcome

Which reminds me, the SBLive has a 29 bit mask in the OSS driver but 31
in the ALSA driver.  I'm going to preserve the discrepancy, it seems
pointless to change the behavior of a deprecated driver.

Lee