From: Jiang zhe <zhe.jiang@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, zhe.jiang@intel.com
Subject: [PATCH]Should use HDA_OUTPUT instead of HDA_INPUT to mute pin 15 of ALC880
Date: Mon, 31 Mar 2008 15:14:49 +0800 [thread overview]
Message-ID: <1206947689.13847.9.camel@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
Hi,
To mute the output of Pin widget 15 in ALC880, we should use the
HDA_OUTPUT. However, current code looks like :
snd_hda_codec_amp_stereo(codec, 0x15, HDA_INPUT, 0, HDA_AMP_MUTE, bits);
It may be a misspelling.
Best regards!
Signed-off-by: Jiang zhe <zhe.jiang@intel.com>
[-- Attachment #2: alc880_pin_15_should_be_HDA_OUTPUT.patch --]
[-- Type: text/x-patch, Size: 603 bytes --]
--- alsa-driver-hg20080323/alsa-kernel/pci/hda/patch_realtek.c 2008-03-23 09:00:08.000000000 +0800
+++ b/alsa-kernel/pci/hda/patch_realtek.c 2008-03-31 14:59:10.000000000 +0800
@@ -1894,7 +1894,7 @@ static void alc880_uniwill_p53_hp_automu
present = snd_hda_codec_read(codec, 0x14, 0,
AC_VERB_GET_PIN_SENSE, 0) & 0x80000000;
bits = present ? HDA_AMP_MUTE : 0;
- snd_hda_codec_amp_stereo(codec, 0x15, HDA_INPUT, 0, HDA_AMP_MUTE, bits);
+ snd_hda_codec_amp_stereo(codec, 0x15, HDA_OUTPUT, 0, HDA_AMP_MUTE, bits);
}
static void alc880_uniwill_p53_dcvol_automute(struct hda_codec *codec)
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
reply other threads:[~2008-03-31 7:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206947689.13847.9.camel@localhost.localdomain \
--to=zhe.jiang@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox