Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH]Should use HDA_OUTPUT instead of HDA_INPUT to mute pin 15 of ALC880
@ 2008-03-31  7:14 Jiang zhe
  0 siblings, 0 replies; only message in thread
From: Jiang zhe @ 2008-03-31  7:14 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, zhe.jiang

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

Hi,

To mute the output of Pin widget 15 in ALC880, we should use the
HDA_OUTPUT. However, current code looks like :
snd_hda_codec_amp_stereo(codec, 0x15, HDA_INPUT, 0, HDA_AMP_MUTE, bits);
It may be a misspelling.

Best regards!

Signed-off-by: Jiang zhe <zhe.jiang@intel.com>

[-- Attachment #2: alc880_pin_15_should_be_HDA_OUTPUT.patch --]
[-- Type: text/x-patch, Size: 603 bytes --]

--- alsa-driver-hg20080323/alsa-kernel/pci/hda/patch_realtek.c	2008-03-23 09:00:08.000000000 +0800
+++ b/alsa-kernel/pci/hda/patch_realtek.c	2008-03-31 14:59:10.000000000 +0800
@@ -1894,7 +1894,7 @@ static void alc880_uniwill_p53_hp_automu
  	present = snd_hda_codec_read(codec, 0x14, 0,
 				     AC_VERB_GET_PIN_SENSE, 0) & 0x80000000;
 	bits = present ? HDA_AMP_MUTE : 0;
-	snd_hda_codec_amp_stereo(codec, 0x15, HDA_INPUT, 0, HDA_AMP_MUTE, bits);
+	snd_hda_codec_amp_stereo(codec, 0x15, HDA_OUTPUT, 0, HDA_AMP_MUTE, bits);
 }
 
 static void alc880_uniwill_p53_dcvol_automute(struct hda_codec *codec)

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-31  7:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-31  7:14 [PATCH]Should use HDA_OUTPUT instead of HDA_INPUT to mute pin 15 of ALC880 Jiang zhe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox