Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: sakoman@gmail.com, broonie@opensource.wolfsonmicro.com
Subject: [PATCH 0/1] ASoC: TWL4030: Constraint setting rework
Date: Fri, 17 Apr 2009 15:55:07 +0300	[thread overview]
Message-ID: <1239972908-4158-1-git-send-email-peter.ujfalusi@nokia.com> (raw)

Hello,

The current implementation of constraints in TWL4030 codec needs some tuning.

An interesting case can be generated by using gstreamer:
gst-launch-0.10 alsasrc device=hw:0 ! alsasink device=hw:0 sync=false

What would (since the current implementation blocks it) happen in this case is:
playback stream: open
capture stream: open
capture stream: hw_params
playback_stream: hw_params

In capture open we set the constraints to the capture stream based on the
playback streams runtime parameters, and they are 0 (rate = 0, sample_bits = 0),
since the hw_param has not been called for that stream yet...

The following patch fixes this issue among other possible scenarios regarding to
constraint handling.

Note that I'm not using the just introduced symmetric_rates feature of ASoC
introduced by Mark Brown recently, since I think that also suffers from this
problem (or not, I have to try it out first to be sure about it)

---
Peter Ujfalusi (1):
  ASoC: TWL4030: Fix for the constraint handling

 sound/soc/codecs/twl4030.c |   85 ++++++++++++++++++++++++++++++++++----------
 1 files changed, 66 insertions(+), 19 deletions(-)

             reply	other threads:[~2009-04-17 12:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-17 12:55 Peter Ujfalusi [this message]
2009-04-17 12:55 ` [PATCH 1/1] ASoC: TWL4030: Fix for the constraint handling Peter Ujfalusi
2009-04-17 14:26   ` Mark Brown
2009-04-20  7:23     ` Peter Ujfalusi
2009-04-20 10:40       ` Mark Brown
2009-04-17 13:38 ` [PATCH 0/1] ASoC: TWL4030: Constraint setting rework Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239972908-4158-1-git-send-email-peter.ujfalusi@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox