From: Mark Brown <broonie@sirena.org.uk>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: sakoman@gmail.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/1] ASoC: TWL4030: Fix for the constraint handling
Date: Fri, 17 Apr 2009 15:26:42 +0100 [thread overview]
Message-ID: <20090417142642.GD10992@sirena.org.uk> (raw)
In-Reply-To: <1239972908-4158-2-git-send-email-peter.ujfalusi@nokia.com>
On Fri, Apr 17, 2009 at 03:55:08PM +0300, Peter Ujfalusi wrote:
> + snd_pcm_hw_constraint_minmax(slv_substream->runtime,
> + SNDRV_PCM_HW_PARAM_RATE,
> + twl4030->rate,
> + twl4030->rate);
You did note this yourself but there's support for this in the core;
it'd be good to switch over to that (and push handling for the other
constraints into core).
> + snd_pcm_hw_constraint_minmax(slv_substream->runtime,
> + SNDRV_PCM_HW_PARAM_SAMPLE_BITS,
> + twl4030->sample_bits,
> + twl4030->sample_bits);
> +
> + snd_pcm_hw_constraint_minmax(slv_substream->runtime,
> + SNDRV_PCM_HW_PARAM_CHANNELS,
> + twl4030->channels,
> + twl4030->channels);
Are you sure that these need to match exactly and don't set maxima?
Your overall approach in the patch looks good so I'll apply it - it's
an improvement on the current situation.
next prev parent reply other threads:[~2009-04-17 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 12:55 [PATCH 0/1] ASoC: TWL4030: Constraint setting rework Peter Ujfalusi
2009-04-17 12:55 ` [PATCH 1/1] ASoC: TWL4030: Fix for the constraint handling Peter Ujfalusi
2009-04-17 14:26 ` Mark Brown [this message]
2009-04-20 7:23 ` Peter Ujfalusi
2009-04-20 10:40 ` Mark Brown
2009-04-17 13:38 ` [PATCH 0/1] ASoC: TWL4030: Constraint setting rework Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417142642.GD10992@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=peter.ujfalusi@nokia.com \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox