Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 08/17] ASoC: Use our registration function for S3C64xx
Date: Tue, 28 Apr 2009 16:23:33 +0100	[thread overview]
Message-ID: <1240932222-3718-8-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20090428152256.GB2244@rakim.wolfsonmicro.main>

Make sure we get the DAI operations initialised.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/s3c24xx/s3c-i2s-v2.c  |   18 ++++++------------
 sound/soc/s3c24xx/s3c64xx-i2s.c |    2 +-
 2 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/sound/soc/s3c24xx/s3c-i2s-v2.c b/sound/soc/s3c24xx/s3c-i2s-v2.c
index aeea49c..ab680aa 100644
--- a/sound/soc/s3c24xx/s3c-i2s-v2.c
+++ b/sound/soc/s3c24xx/s3c-i2s-v2.c
@@ -105,9 +105,7 @@ void s3c2412_snd_txctrl(struct s3c_i2sv2_info *i2s, int on)
 			break;
 
 		default:
-			dev_err(i2s->dev, "TXEN: Invalid MODE %x in IISMOD\n",
-				mod & S3C2412_IISMOD_MODE_MASK);
-			break;
+			dev_err(i2s->dev, "TXEN: Invalid MODE in IISMOD\n");
 		}
 
 		writel(con, regs + S3C2412_IISCON);
@@ -134,9 +132,7 @@ void s3c2412_snd_txctrl(struct s3c_i2sv2_info *i2s, int on)
 			break;
 
 		default:
-			dev_err(i2s->dev, "TXDIS: Invalid MODE %xin IISMOD\n",
-				mod & S3C2412_IISMOD_MODE_MASK);
-			break;
+			dev_err(i2s->dev, "TXDIS: Invalid MODE in IISMOD\n");
 		}
 
 		writel(mod, regs + S3C2412_IISMOD);
@@ -179,8 +175,7 @@ void s3c2412_snd_rxctrl(struct s3c_i2sv2_info *i2s, int on)
 			break;
 
 		default:
-			dev_err(i2s->dev, "RXEN: Invalid MODE %x in IISMOD\n",
-				mod & S3C2412_IISMOD_MODE_MASK);
+			dev_err(i2s->dev, "RXEN: Invalid MODE in IISMOD\n");
 		}
 
 		writel(mod, regs + S3C2412_IISMOD);
@@ -204,8 +199,7 @@ void s3c2412_snd_rxctrl(struct s3c_i2sv2_info *i2s, int on)
 			break;
 
 		default:
-			dev_err(i2s->dev, "RXEN: Invalid MODE %x in IISMOD\n",
-				mod & S3C2412_IISMOD_MODE_MASK);
+			dev_err(i2s->dev, "RXEN: Invalid MODE in IISMOD\n");
 		}
 
 		writel(con, regs + S3C2412_IISCON);
@@ -287,7 +281,7 @@ static int s3c2412_i2s_set_fmt(struct snd_soc_dai *cpu_dai,
 		iismod |= IISMOD_MASTER;
 		break;
 	default:
-		pr_err("unknwon master/slave format\n");
+		pr_debug("unknwon master/slave format\n");
 		return -EINVAL;
 	}
 
@@ -304,7 +298,7 @@ static int s3c2412_i2s_set_fmt(struct snd_soc_dai *cpu_dai,
 		iismod |= S3C2412_IISMOD_SDF_IIS;
 		break;
 	default:
-		pr_err("Unknown data format\n");
+		pr_debug("Unknown data format\n");
 		return -EINVAL;
 	}
 
diff --git a/sound/soc/s3c24xx/s3c64xx-i2s.c b/sound/soc/s3c24xx/s3c64xx-i2s.c
index c335248..1345fbd 100644
--- a/sound/soc/s3c24xx/s3c64xx-i2s.c
+++ b/sound/soc/s3c24xx/s3c64xx-i2s.c
@@ -225,7 +225,7 @@ static __devinit int s3c64xx_iis_dev_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_clk;
 
-	ret = snd_soc_register_dai(dai);
+	ret = s3c_i2sv2_register_dai(dai);
 	if (ret != 0)
 		goto err_i2sv2;
 
-- 
1.6.2.4

  parent reply	other threads:[~2009-04-28 15:23 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 15:22 ASoC updates for 2.6.31 Mark Brown
2009-04-28 15:23 ` [PATCH 01/17] ASoC: Beagle: Add support for 4 channel Mark Brown
2009-04-28 15:23 ` [PATCH 02/17] ASoC: add SOC_DOUBLE_EXT macro Mark Brown
2009-04-28 15:23 ` [PATCH 03/17] ASoC: Fix S3C64xx IIS device registration and support both ports Mark Brown
2009-04-28 15:23 ` [PATCH 04/17] ASoC: S3C2412: Failing to get the I2S clock is an error Mark Brown
2009-04-28 15:23 ` [PATCH 05/17] ASoC: Enforce symmetric rates for S3C64xx I2S interface Mark Brown
2009-04-28 15:23 ` [PATCH 06/17] ASoC: Include WM8350 register definitions in CODEC header Mark Brown
2009-04-28 15:23 ` [PATCH 07/17] ASoC: s3c-i2s-v2 diagnostic improvements Mark Brown
2009-04-28 15:23 ` Mark Brown [this message]
2009-04-28 15:23 ` [PATCH 09/17] ASoC WM8940 Driver Mark Brown
2009-04-28 15:23 ` [PATCH 10/17] ASoC: cs4270: fix Master Capture Switch polarity Mark Brown
2009-04-28 15:23 ` [PATCH 11/17] ASoC: cs4270: add Master Playback Switch Mark Brown
2009-04-28 15:23 ` [PATCH 12/17] ASoC: Fix logic in WM8350 master clocking check Mark Brown
2009-04-28 15:23 ` [PATCH 13/17] ASoC: Set the MPC5200 i2s driver to BROKEN status Mark Brown
2009-04-28 15:23 ` [PATCH 14/17] ASoC: Staticise TLV values in WM8940 Mark Brown
2009-04-28 15:23 ` [PATCH 15/17] ASoC: TWL4030: Fix gain control for earpiece amplifier Mark Brown
2009-04-28 15:23 ` [PATCH 16/17] ASoC: Basic split of mpc5200 DMA code out from mpc5200_psc_i2s Mark Brown
2009-04-28 15:46   ` Takashi Iwai
2009-04-28 15:59     ` Jon Smirl
2009-04-28 16:51       ` Takashi Iwai
2009-04-28 16:55         ` Jon Smirl
2009-04-28 17:14           ` Jon Smirl
2009-04-28 19:37             ` Takashi Iwai
2009-04-28 19:53               ` Mark Brown
2009-04-28 19:59                 ` Jon Smirl
2009-04-28 20:16                   ` Jon Smirl
2009-04-28 21:01                   ` Mark Brown
2009-04-28 22:06                   ` Takashi Iwai
2009-04-28 21:59                 ` Takashi Iwai
2009-04-28 19:35           ` Takashi Iwai
2009-04-28 19:37           ` Mark Brown
2009-04-28 19:25     ` Mark Brown
2009-04-28 19:32       ` Jon Smirl
2009-04-28 19:50         ` Mark Brown
2009-04-28 21:52       ` Takashi Iwai
2009-04-28 15:23 ` [PATCH 17/17] ASoC: Rename the PSC functions to DMA Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240932222-3718-8-git-send-email-broonie@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox