Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 2/8] ASoC: Remove unused AK4535 hardware read functionality
Date: Mon,  3 Aug 2009 17:09:44 +0100	[thread overview]
Message-ID: <1249315790-22814-2-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1249315790-22814-1-git-send-email-broonie@opensource.wolfsonmicro.com>

Nothing uses it and the existing hw_read operation needs to be
refectored so it's easier to remove it rather than work with it.
Support can be re-added if the code requires volatile registers.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/ak4535.c |   16 ----------------
 1 files changed, 0 insertions(+), 16 deletions(-)

diff --git a/sound/soc/codecs/ak4535.c b/sound/soc/codecs/ak4535.c
index dd33802..0abec0d 100644
--- a/sound/soc/codecs/ak4535.c
+++ b/sound/soc/codecs/ak4535.c
@@ -59,21 +59,6 @@ static inline unsigned int ak4535_read_reg_cache(struct snd_soc_codec *codec,
 	return cache[reg];
 }
 
-static inline unsigned int ak4535_read(struct snd_soc_codec *codec,
-	unsigned int reg)
-{
-	u8 data;
-	data = reg;
-
-	if (codec->hw_write(codec->control_data, &data, 1) != 1)
-		return -EIO;
-
-	if (codec->hw_read(codec->control_data, &data, 1) != 1)
-		return -EIO;
-
-	return data;
-};
-
 /*
  * write ak4535 register cache
  */
@@ -635,7 +620,6 @@ static int ak4535_probe(struct platform_device *pdev)
 #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
 	if (setup->i2c_address) {
 		codec->hw_write = (hw_write_t)i2c_master_send;
-		codec->hw_read = (hw_read_t)i2c_master_recv;
 		ret = ak4535_add_i2c_device(pdev, setup);
 	}
 #endif
-- 
1.6.3.3

  reply	other threads:[~2009-08-03 16:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03 16:09 [PATCH 1/8] ASoC: Begin to factor out register cache I/O functions Mark Brown
2009-08-03 16:09 ` Mark Brown [this message]
2009-08-03 16:09   ` [PATCH 3/8] ASoC: Remove use of hw_read from TLV320AIC3x driver Mark Brown
2009-08-03 16:09     ` [PATCH 4/8] ASoC: Factor out WM8580 register cache code Mark Brown
2009-08-03 16:09       ` [PATCH 5/8] ASoC: Add I/O control bus information to factored out cache setup Mark Brown
2009-08-03 16:09         ` [PATCH 6/8] ASoC: Factor out I2C 8 bit address 16 bit data I/O Mark Brown
2009-08-03 16:09           ` [PATCH 7/8] ASoC: Factor out I/O for Wolfson 8 bit data 16 bit register CODECs Mark Brown
2009-08-03 16:09             ` [PATCH 8/8] ASoC: Factor out 7 bit register 9 bit data SPI write Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249315790-22814-2-git-send-email-broonie@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox