From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: alsa-devel@alsa-project.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 3/8] ASoC: Remove use of hw_read from TLV320AIC3x driver
Date: Mon, 3 Aug 2009 17:09:45 +0100 [thread overview]
Message-ID: <1249315790-22814-3-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1249315790-22814-2-git-send-email-broonie@opensource.wolfsonmicro.com>
The TLV320AIC3x driver is currently the only user of the CODEC hw_read
operation and is jumping through some hoops in order to do so. In order
to support future refactoring to make the hw_read operation more usable
unwrap the usage in this driver to avoid its use.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/tlv320aic3x.c | 11 ++---------
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index ab099f4..0cf401f 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -145,8 +145,8 @@ static int aic3x_read(struct snd_soc_codec *codec, unsigned int reg,
u8 *value)
{
*value = reg & 0xff;
- if (codec->hw_read(codec->control_data, value, 1) != 1)
- return -EIO;
+
+ value[0] = i2c_smbus_read_byte_data(codec->control_data, value[0]);
aic3x_write_reg_cache(codec, reg, *value);
return 0;
@@ -1316,12 +1316,6 @@ static struct i2c_driver aic3x_i2c_driver = {
.id_table = aic3x_i2c_id,
};
-static int aic3x_i2c_read(struct i2c_client *client, u8 *value, int len)
-{
- value[0] = i2c_smbus_read_byte_data(client, value[0]);
- return (len == 1);
-}
-
static int aic3x_add_i2c_device(struct platform_device *pdev,
const struct aic3x_setup_data *setup)
{
@@ -1394,7 +1388,6 @@ static int aic3x_probe(struct platform_device *pdev)
#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
if (setup->i2c_address) {
codec->hw_write = (hw_write_t) i2c_master_send;
- codec->hw_read = (hw_read_t) aic3x_i2c_read;
ret = aic3x_add_i2c_device(pdev, setup);
}
#else
--
1.6.3.3
next prev parent reply other threads:[~2009-08-03 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 16:09 [PATCH 1/8] ASoC: Begin to factor out register cache I/O functions Mark Brown
2009-08-03 16:09 ` [PATCH 2/8] ASoC: Remove unused AK4535 hardware read functionality Mark Brown
2009-08-03 16:09 ` Mark Brown [this message]
2009-08-03 16:09 ` [PATCH 4/8] ASoC: Factor out WM8580 register cache code Mark Brown
2009-08-03 16:09 ` [PATCH 5/8] ASoC: Add I/O control bus information to factored out cache setup Mark Brown
2009-08-03 16:09 ` [PATCH 6/8] ASoC: Factor out I2C 8 bit address 16 bit data I/O Mark Brown
2009-08-03 16:09 ` [PATCH 7/8] ASoC: Factor out I/O for Wolfson 8 bit data 16 bit register CODECs Mark Brown
2009-08-03 16:09 ` [PATCH 8/8] ASoC: Factor out 7 bit register 9 bit data SPI write Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249315790-22814-3-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox