From: Troy Kisky <troy.kisky@boundarydevices.com>
To: davinci-linux-open-source@linux.davincidsp.com
Cc: alsa-devel@alsa-project.org, broonie@sirena.org.uk,
Troy Kisky <troy.kisky@boundarydevices.com>
Subject: [PATCH 4/5] ASoC: DaVinci: pcm, rename variables in prep for ping/pong
Date: Thu, 6 Aug 2009 16:55:34 -0700 [thread overview]
Message-ID: <1249602935-1267-4-git-send-email-troy.kisky@boundarydevices.com> (raw)
In-Reply-To: <1249602935-1267-3-git-send-email-troy.kisky@boundarydevices.com>
Rename variable master_lch to asp_master_lch
Rename variable slave_lch to asp_link_lch[0]
Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
---
sound/soc/davinci/davinci-pcm.c | 38 +++++++++++++++++++-------------------
1 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/sound/soc/davinci/davinci-pcm.c b/sound/soc/davinci/davinci-pcm.c
index a294711..3489f18 100644
--- a/sound/soc/davinci/davinci-pcm.c
+++ b/sound/soc/davinci/davinci-pcm.c
@@ -51,8 +51,8 @@ static struct snd_pcm_hardware davinci_pcm_hardware = {
struct davinci_runtime_data {
spinlock_t lock;
int period; /* current DMA period */
- int master_lch; /* Master DMA channel */
- int slave_lch; /* linked parameter RAM reload slot */
+ int asp_master_lch; /* Master DMA channel */
+ int asp_link_lch[2]; /* asp parameter link channel, ping/pong */
struct davinci_pcm_dma_params *params; /* DMA params */
};
@@ -60,7 +60,7 @@ static void davinci_pcm_enqueue_dma(struct snd_pcm_substream *substream)
{
struct davinci_runtime_data *prtd = substream->runtime->private_data;
struct snd_pcm_runtime *runtime = substream->runtime;
- int lch = prtd->slave_lch;
+ int lch = prtd->asp_link_lch[0];
unsigned int period_size;
unsigned int dma_offset;
dma_addr_t dma_pos;
@@ -140,15 +140,15 @@ static int davinci_pcm_dma_request(struct snd_pcm_substream *substream)
EVENTQ_0);
if (ret < 0)
return ret;
- prtd->master_lch = ret;
+ prtd->asp_master_lch = ret;
/* Request parameter RAM reload slot */
- ret = edma_alloc_slot(EDMA_CTLR(prtd->master_lch), EDMA_SLOT_ANY);
+ ret = edma_alloc_slot(EDMA_CTLR(prtd->asp_master_lch), EDMA_SLOT_ANY);
if (ret < 0) {
- edma_free_channel(prtd->master_lch);
+ edma_free_channel(prtd->asp_master_lch);
return ret;
}
- prtd->slave_lch = ret;
+ prtd->asp_link_lch[0] = ret;
/* Issue transfer completion IRQ when the channel completes a
* transfer, then always reload from the same slot (by a kind
@@ -159,10 +159,10 @@ static int davinci_pcm_dma_request(struct snd_pcm_substream *substream)
* the buffer and its length (ccnt) ... use it as a template
* so davinci_pcm_enqueue_dma() takes less time in IRQ.
*/
- edma_read_slot(prtd->slave_lch, &p_ram);
- p_ram.opt |= TCINTEN | EDMA_TCC(EDMA_CHAN_SLOT(prtd->master_lch));
- p_ram.link_bcntrld = EDMA_CHAN_SLOT(prtd->slave_lch) << 5;
- edma_write_slot(prtd->slave_lch, &p_ram);
+ edma_read_slot(prtd->asp_link_lch[0], &p_ram);
+ p_ram.opt |= TCINTEN | EDMA_TCC(EDMA_CHAN_SLOT(prtd->asp_master_lch));
+ p_ram.link_bcntrld = EDMA_CHAN_SLOT(prtd->asp_link_lch[0]) << 5;
+ edma_write_slot(prtd->asp_link_lch[0], &p_ram);
return 0;
}
@@ -178,12 +178,12 @@ static int davinci_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
case SNDRV_PCM_TRIGGER_START:
case SNDRV_PCM_TRIGGER_RESUME:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
- edma_start(prtd->master_lch);
+ edma_start(prtd->asp_master_lch);
break;
case SNDRV_PCM_TRIGGER_STOP:
case SNDRV_PCM_TRIGGER_SUSPEND:
case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
- edma_stop(prtd->master_lch);
+ edma_stop(prtd->asp_master_lch);
break;
default:
ret = -EINVAL;
@@ -204,8 +204,8 @@ static int davinci_pcm_prepare(struct snd_pcm_substream *substream)
davinci_pcm_enqueue_dma(substream);
/* Copy self-linked parameter RAM entry into master channel */
- edma_read_slot(prtd->slave_lch, &temp);
- edma_write_slot(prtd->master_lch, &temp);
+ edma_read_slot(prtd->asp_link_lch[0], &temp);
+ edma_write_slot(prtd->asp_master_lch, &temp);
davinci_pcm_enqueue_dma(substream);
return 0;
@@ -222,7 +222,7 @@ davinci_pcm_pointer(struct snd_pcm_substream *substream)
spin_lock(&prtd->lock);
- edma_get_position(prtd->master_lch, &src, &dst);
+ edma_get_position(prtd->asp_master_lch, &src, &dst);
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
count = src - runtime->dma_addr;
else
@@ -272,10 +272,10 @@ static int davinci_pcm_close(struct snd_pcm_substream *substream)
struct snd_pcm_runtime *runtime = substream->runtime;
struct davinci_runtime_data *prtd = runtime->private_data;
- edma_unlink(prtd->slave_lch);
+ edma_unlink(prtd->asp_link_lch[0]);
- edma_free_slot(prtd->slave_lch);
- edma_free_channel(prtd->master_lch);
+ edma_free_slot(prtd->asp_link_lch[0]);
+ edma_free_channel(prtd->asp_master_lch);
kfree(prtd);
--
1.5.6.3
next prev parent reply other threads:[~2009-08-06 23:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 23:55 [PATCH 1/5] ASoC: DaVinci: i2s: don't bounce through rtd to get dai Troy Kisky
[not found] ` <1249602935-1267-1-git-send-email-troy.kisky-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2009-08-06 23:55 ` [PATCH 2/5] ASoC: DaVinci: pcm, constrain buffer size to multiple of period Troy Kisky
2009-08-06 23:55 ` [PATCH 3/5] ASoC: DaVinci: i2s, reduce underruns by combining into 1 element Troy Kisky
2009-08-06 23:55 ` Troy Kisky [this message]
2009-08-06 23:55 ` [PATCH 5/5] ASoC: DaVinci: pcm, fix underruns by using sram Troy Kisky
2009-08-07 2:05 ` Troy Kisky
2009-08-08 9:17 ` Mark Brown
2009-08-11 0:32 ` Troy Kisky
2009-08-11 9:59 ` Mark Brown
2009-08-08 8:59 ` [PATCH 3/5] ASoC: DaVinci: i2s, reduce underruns by combining into 1 element Mark Brown
2009-08-08 9:07 ` Mark Brown
2009-08-07 10:41 ` [PATCH 1/5] ASoC: DaVinci: i2s: don't bounce through rtd to get dai Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249602935-1267-4-git-send-email-troy.kisky@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=davinci-linux-open-source@linux.davincidsp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox