From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Troy Kisky <troy.kisky@boundarydevices.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 5/5] ASoC: DaVinci: pcm, fix underruns by using sram
Date: Sat, 8 Aug 2009 10:17:08 +0100 [thread overview]
Message-ID: <20090808091708.GG4519@sirena.org.uk> (raw)
In-Reply-To: <4A7B8C02.6020902@boundarydevices.com>
On Thu, Aug 06, 2009 at 07:05:54PM -0700, Troy Kisky wrote:
> This is allocated too late for the "ensure that buffer size is a multiple of period size"
> constraint.
> I have a patch after fixing other feedback.
It looks good to me - I've no issues with the patch except for the one I
mentioned last time about considering ignoring the data in SRAM when
reporting the current position but I'm happy either way. The patch will
run into the cross tree issues with the platform data like the channel
combining one, probably best to submit patches against Kevin's tree for
now (or wait until after the merge window).
Have you tested with PulseAudio? If not it'd be worth giving it a spin
- it's one of the more demanding applications.
next prev parent reply other threads:[~2009-08-08 9:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 23:55 [PATCH 1/5] ASoC: DaVinci: i2s: don't bounce through rtd to get dai Troy Kisky
[not found] ` <1249602935-1267-1-git-send-email-troy.kisky-Q5RJGjKts06CY9SHAMCTRUEOCMrvLtNR@public.gmane.org>
2009-08-06 23:55 ` [PATCH 2/5] ASoC: DaVinci: pcm, constrain buffer size to multiple of period Troy Kisky
2009-08-06 23:55 ` [PATCH 3/5] ASoC: DaVinci: i2s, reduce underruns by combining into 1 element Troy Kisky
2009-08-06 23:55 ` [PATCH 4/5] ASoC: DaVinci: pcm, rename variables in prep for ping/pong Troy Kisky
2009-08-06 23:55 ` [PATCH 5/5] ASoC: DaVinci: pcm, fix underruns by using sram Troy Kisky
2009-08-07 2:05 ` Troy Kisky
2009-08-08 9:17 ` Mark Brown [this message]
2009-08-11 0:32 ` Troy Kisky
2009-08-11 9:59 ` Mark Brown
2009-08-08 8:59 ` [PATCH 3/5] ASoC: DaVinci: i2s, reduce underruns by combining into 1 element Mark Brown
2009-08-08 9:07 ` Mark Brown
2009-08-07 10:41 ` [PATCH 1/5] ASoC: DaVinci: i2s: don't bounce through rtd to get dai Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090808091708.GG4519@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox