From: Liam Girdwood <lrg@slimlogic.co.uk>
To: "Eric Bénard" <eric@eukrea.com>
Cc: anuj.aggarwal@ti.com, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2] codecs/tlv320aic23: fix bias management for suspend/resume
Date: Tue, 22 Jun 2010 11:07:04 +0100 [thread overview]
Message-ID: <1277201224.4537.1.camel@odin> (raw)
In-Reply-To: <1276968819-17285-1-git-send-email-eric@eukrea.com>
On Sat, 2010-06-19 at 19:33 +0200, Eric Bénard wrote:
> in tlv320aic23_set_bias_level, for the case SND_SOC_BIAS_ON, the
> comment says "vref/mid, osc on, dac unmute" but the code doesn't
> clear the corresponding bits, thus when resuming, several bits are
> not cleared preventing the codec from working.
>
> in tlv320aic23_suspend, clearing the active register is not needed
> as it will be done by tlv320aic23_set_bias_level, when setting
> bias to SND_SOC_BIAS_OFF
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> Cc: broonie@opensource.wolfsonmicro.com
> Cc: anuj.aggarwal@ti.com
> Cc: lrg@slimlogic.co.uk
> ---
> v2:
> fix the problem in tlv320aic23_set_bias_level instead of the
> previous bad workaround in suspend.
>
> sound/soc/codecs/tlv320aic23.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2010-06-22 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 8:56 [PATCH] codecs/tlv320aic23: fix suspend/resume Eric Bénard
2010-06-19 10:59 ` Mark Brown
2010-06-19 12:07 ` Eric Bénard
2010-06-19 17:33 ` [PATCH v2] codecs/tlv320aic23: fix bias management for suspend/resume Eric Bénard
2010-06-22 10:07 ` Liam Girdwood [this message]
2010-06-22 23:17 ` Mark Brown
2010-06-23 10:35 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277201224.4537.1.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=anuj.aggarwal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric@eukrea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox