From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: anuj.aggarwal@ti.com, alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH v2] codecs/tlv320aic23: fix bias management for suspend/resume
Date: Wed, 23 Jun 2010 00:17:53 +0100 [thread overview]
Message-ID: <20100622231752.GC2453@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1276968819-17285-1-git-send-email-eric@eukrea.com>
On Sat, Jun 19, 2010 at 07:33:39PM +0200, Eric Bénard wrote:
> in tlv320aic23_set_bias_level, for the case SND_SOC_BIAS_ON, the
> comment says "vref/mid, osc on, dac unmute" but the code doesn't
> clear the corresponding bits, thus when resuming, several bits are
> not cleared preventing the codec from working.
Sorry - I should've registered that this was one that should go through
Liam's tree
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2010-06-22 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 8:56 [PATCH] codecs/tlv320aic23: fix suspend/resume Eric Bénard
2010-06-19 10:59 ` Mark Brown
2010-06-19 12:07 ` Eric Bénard
2010-06-19 17:33 ` [PATCH v2] codecs/tlv320aic23: fix bias management for suspend/resume Eric Bénard
2010-06-22 10:07 ` Liam Girdwood
2010-06-22 23:17 ` Mark Brown [this message]
2010-06-23 10:35 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100622231752.GC2453@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=anuj.aggarwal@ti.com \
--cc=eric@eukrea.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox