[PATCH] ASoC: TWL4030: Capture route DAPM event fix

[PATCH] ASoC: TWL4030: Capture route DAPM event fix

[Peter Ujfalusi]

There is no need to handle POST_PMU, POST_PMD event with
the Capture Route widget.
It is enough to handle POST_REG event, since that will come
when the user changes the routing, and we will switch the needed
bits in the registers.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
 sound/soc/codecs/twl4030.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index bd557c2..d401c59 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -1432,11 +1432,9 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
 	   TX2 Left/Right: either analog Left/Right or Digimic1 */
 	SND_SOC_DAPM_MUX_E("TX1 Capture Route", SND_SOC_NOPM, 0, 0,
 		&twl4030_dapm_micpathtx1_control, micpath_event,
-		SND_SOC_DAPM_POST_PMU|SND_SOC_DAPM_POST_PMD|
 		SND_SOC_DAPM_POST_REG),
 	SND_SOC_DAPM_MUX_E("TX2 Capture Route", SND_SOC_NOPM, 0, 0,
 		&twl4030_dapm_micpathtx2_control, micpath_event,
-		SND_SOC_DAPM_POST_PMU|SND_SOC_DAPM_POST_PMD|
 		SND_SOC_DAPM_POST_REG),
 
 	/* Analog input mixers for the capture amplifiers */
-- 
1.7.1.1

Re: [PATCH] ASoC: TWL4030: Capture route DAPM event fix

[Mark Brown]

On 25 Jul 2010, at 23:59, Peter Ujfalusi <peter.ujfalusi@Nokia.com> wrote:

> There is no need to handle POST_PMU, POST_PMD event with
> the Capture Route widget.
> It is enough to handle POST_REG event, since that will come
> when the user changes the routing, and we will switch the needed
> bits in the registers.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

> ---
> sound/soc/codecs/twl4030.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
> index bd557c2..d401c59 100644
> --- a/sound/soc/codecs/twl4030.c
> +++ b/sound/soc/codecs/twl4030.c
> @@ -1432,11 +1432,9 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
>  	   TX2 Left/Right: either analog Left/Right or Digimic1 */
>  	SND_SOC_DAPM_MUX_E("TX1 Capture Route", SND_SOC_NOPM, 0, 0,
>  		&twl4030_dapm_micpathtx1_control, micpath_event,
> -		SND_SOC_DAPM_POST_PMU|SND_SOC_DAPM_POST_PMD|
>  		SND_SOC_DAPM_POST_REG),
>  	SND_SOC_DAPM_MUX_E("TX2 Capture Route", SND_SOC_NOPM, 0, 0,
>  		&twl4030_dapm_micpathtx2_control, micpath_event,
> -		SND_SOC_DAPM_POST_PMU|SND_SOC_DAPM_POST_PMD|
>  		SND_SOC_DAPM_POST_REG),
> 
>  	/* Analog input mixers for the capture amplifiers */
> -- 
> 1.7.1.1
> 

Re: [PATCH] ASoC: TWL4030: Capture route DAPM event fix

[Liam Girdwood]

On Mon, 2010-07-26 at 09:59 +0300, Peter Ujfalusi wrote:
> There is no need to handle POST_PMU, POST_PMD event with
> the Capture Route widget.
> It is enough to handle POST_REG event, since that will come
> when the user changes the routing, and we will switch the needed
> bits in the registers.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk