* [PATCH 07/10] ALSA: sb: check get_user() return value
@ 2010-07-28 16:40 Kulikov Vasiliy
2010-07-29 10:31 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-07-28 16:40 UTC (permalink / raw)
To: kernel-janitors
Cc: Jaroslav Kysela, Takashi Iwai, Tejun Heo, alsa-devel,
linux-kernel
get_user() may fail, if so return -EFAULT.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
sound/isa/sb/emu8000_pcm.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/isa/sb/emu8000_pcm.c b/sound/isa/sb/emu8000_pcm.c
index ccedbfe..ae6fa9f 100644
--- a/sound/isa/sb/emu8000_pcm.c
+++ b/sound/isa/sb/emu8000_pcm.c
@@ -433,7 +433,8 @@ static int emu8k_transfer_block(struct snd_emu8000 *emu, int offset, unsigned sh
while (count > 0) {
unsigned short sval;
CHECK_SCHEDULER();
- get_user(sval, buf);
+ if (get_user(sval, buf))
+ return -EFAULT;
EMU8000_SMLD_WRITE(emu, sval);
buf++;
count--;
@@ -525,7 +526,8 @@ static int emu8k_pcm_copy(struct snd_pcm_substream *subs,
while (count-- > 0) {
unsigned short sval;
CHECK_SCHEDULER();
- get_user(sval, buf);
+ if (get_user(sval, buf))
+ return -EFAULT;
EMU8000_SMLD_WRITE(emu, sval);
buf++;
if (rec->voices > 1) {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 07/10] ALSA: sb: check get_user() return value
2010-07-28 16:40 [PATCH 07/10] ALSA: sb: check get_user() return value Kulikov Vasiliy
@ 2010-07-29 10:31 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2010-07-29 10:31 UTC (permalink / raw)
To: Kulikov Vasiliy; +Cc: Tejun Heo, alsa-devel, kernel-janitors, linux-kernel
At Wed, 28 Jul 2010 20:40:51 +0400,
Kulikov Vasiliy wrote:
>
> get_user() may fail, if so return -EFAULT.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Thanks, applied this one (with one additional fix for get_user() there).
Takashi
> ---
> sound/isa/sb/emu8000_pcm.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/sound/isa/sb/emu8000_pcm.c b/sound/isa/sb/emu8000_pcm.c
> index ccedbfe..ae6fa9f 100644
> --- a/sound/isa/sb/emu8000_pcm.c
> +++ b/sound/isa/sb/emu8000_pcm.c
> @@ -433,7 +433,8 @@ static int emu8k_transfer_block(struct snd_emu8000 *emu, int offset, unsigned sh
> while (count > 0) {
> unsigned short sval;
> CHECK_SCHEDULER();
> - get_user(sval, buf);
> + if (get_user(sval, buf))
> + return -EFAULT;
> EMU8000_SMLD_WRITE(emu, sval);
> buf++;
> count--;
> @@ -525,7 +526,8 @@ static int emu8k_pcm_copy(struct snd_pcm_substream *subs,
> while (count-- > 0) {
> unsigned short sval;
> CHECK_SCHEDULER();
> - get_user(sval, buf);
> + if (get_user(sval, buf))
> + return -EFAULT;
> EMU8000_SMLD_WRITE(emu, sval);
> buf++;
> if (rec->voices > 1) {
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-29 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-28 16:40 [PATCH 07/10] ALSA: sb: check get_user() return value Kulikov Vasiliy
2010-07-29 10:31 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox