From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
"Janusz Krzysztofik" <jkrzyszt@tis.icnet.pl>,
"Gražvydas Ignotas" <notasas@gmail.com>,
"Anuj Aggarwal" <anuj.aggarwal@ti.com>,
"Misael Lopez Cruz" <misael.lopez@ti.com>,
"Liam Girdwood" <lrg@ti.com>,
"Jarkko Nikula" <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH] ASoC: OMAP machines: Fix kernel crash due to changes in core
Date: Fri, 07 Oct 2011 07:21:32 -0700 (PDT) [thread overview]
Message-ID: <1375918.bhdBV2GSbL@barack> (raw)
In-Reply-To: <20111007134635.GG14518@opensource.wolfsonmicro.com>
On Friday 07 October 2011 14:46:36 Mark Brown wrote:
> > - From the remaining drivers the soc_dapm_sync need to be removed. If
> > they do funky stuff with their widgets we might need to add
> > snd_soc_dapm_new_widgets() for their init call to be sure they are not
> > crashing.
>
> new_widgets() is orthogonal to the sync(), there is now a stronger
> requirement for it though.
Yes, new_widgets() is instantiating the new widgets + sync()
IMHO it is going to be rare case when machine drivers would need to do this.
> > I have converted some of the OMAP machine drivers according to point 2
> > after this patch. I only changed those which seamed obvious.
>
> Yeah, I didn't apply all those patches as they depended on this one.
I'll rewrite the series to skip the sync -> new_widgets() step.
--
Péter
prev parent reply other threads:[~2011-10-07 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 7:06 [PATCH] ASoC: OMAP machines: Fix kernel crash due to changes in core Peter Ujfalusi
2011-10-07 10:17 ` Mark Brown
2011-10-07 10:40 ` Péter Ujfalusi
2011-10-07 10:48 ` Mark Brown
2011-10-07 11:12 ` Péter Ujfalusi
2011-10-07 11:46 ` Péter Ujfalusi
2011-10-07 11:47 ` Mark Brown
2011-10-07 13:14 ` Péter Ujfalusi
2011-10-07 13:46 ` Mark Brown
2011-10-07 14:21 ` Péter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375918.bhdBV2GSbL@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=anuj.aggarwal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jarkko.nikula@bitmer.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox