From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Liam Girdwood <lgirdwood@gmail.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
kbuild test robot <fengguang.wu@intel.com>
Subject: [PATCHv2] ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'
Date: Wed, 26 Feb 2014 15:31:46 +0200 [thread overview]
Message-ID: <1393421506-2411-1-git-send-email-jarkko.nikula@linux.intel.com> (raw)
In-Reply-To: <1393420341-31625-1-git-send-email-jarkko.nikula@linux.intel.com>
Some kernel configurations can cause following build error:
sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
memcpy_fromio(&fw_tstamp,
^
cc1: some warnings being treated as errors
Fix this by including <linux/io.h> explicitly.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
v2: including <linux/io.h> instead of <asm/io.h>. Thanks to Takashi Iwai for
noticing (checkpatch.pl tells it too).
Also sst-dsp., sst-baytrail-dsp.c and sst-haswell-dsp.c are using
memcpy_fromio/_toio but there <asm/io.h> seems to come via
<linux/dma-mapping.h> or <linux/io.h> so I didn't touch them.
---
sound/soc/intel/sst-baytrail-ipc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/intel/sst-baytrail-ipc.c b/sound/soc/intel/sst-baytrail-ipc.c
index 8c91a68b90bc..c12e194bbc6b 100644
--- a/sound/soc/intel/sst-baytrail-ipc.c
+++ b/sound/soc/intel/sst-baytrail-ipc.c
@@ -26,6 +26,7 @@
#include <linux/platform_device.h>
#include <linux/kthread.h>
#include <linux/firmware.h>
+#include <linux/io.h>
#include <asm/div64.h>
#include "sst-baytrail-ipc.h"
--
1.8.5.3
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-02-26 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 13:12 [PATCH] ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio' Jarkko Nikula
2014-02-26 13:18 ` Takashi Iwai
2014-02-26 13:31 ` Jarkko Nikula [this message]
2014-02-26 14:47 ` [PATCHv2] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393421506-2411-1-git-send-email-jarkko.nikula@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fengguang.wu@intel.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox