[PATCH] ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

[PATCH] ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

[Jarkko Nikula]

Some kernel configurations can cause following build error:

sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
  memcpy_fromio(&fw_tstamp,
  ^
cc1: some warnings being treated as errors

Fix this by including <asm/io.h> explicitly.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
Also sst-dsp., sst-baytrail-dsp.c and sst-haswell-dsp.c are using
memcpy_fromio/_toio but there <asm/io.h> seems to come via
<linux/dma-mapping.h> or <linux/io.h> so I didn't touch them.
---
 sound/soc/intel/sst-baytrail-ipc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/intel/sst-baytrail-ipc.c b/sound/soc/intel/sst-baytrail-ipc.c
index 8c91a68b90bc..8b067e34094e 100644
--- a/sound/soc/intel/sst-baytrail-ipc.c
+++ b/sound/soc/intel/sst-baytrail-ipc.c
@@ -27,6 +27,7 @@
 #include <linux/kthread.h>
 #include <linux/firmware.h>
 #include <asm/div64.h>
+#include <asm/io.h>
 
 #include "sst-baytrail-ipc.h"
 #include "sst-dsp.h"
-- 
1.8.5.3

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

[Takashi Iwai]

At Wed, 26 Feb 2014 15:12:21 +0200,
Jarkko Nikula wrote:
> 
> Some kernel configurations can cause following build error:
> 
> sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
> sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
>   memcpy_fromio(&fw_tstamp,
>   ^
> cc1: some warnings being treated as errors
> 
> Fix this by including <asm/io.h> explicitly.

linux/io.h should be included instead, as checkpatch.pl would
suggest.


Takashi

> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> Also sst-dsp., sst-baytrail-dsp.c and sst-haswell-dsp.c are using
> memcpy_fromio/_toio but there <asm/io.h> seems to come via
> <linux/dma-mapping.h> or <linux/io.h> so I didn't touch them.
> ---
>  sound/soc/intel/sst-baytrail-ipc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/sst-baytrail-ipc.c b/sound/soc/intel/sst-baytrail-ipc.c
> index 8c91a68b90bc..8b067e34094e 100644
> --- a/sound/soc/intel/sst-baytrail-ipc.c
> +++ b/sound/soc/intel/sst-baytrail-ipc.c
> @@ -27,6 +27,7 @@
>  #include <linux/kthread.h>
>  #include <linux/firmware.h>
>  #include <asm/div64.h>
> +#include <asm/io.h>
>  
>  #include "sst-baytrail-ipc.h"
>  #include "sst-dsp.h"
> -- 
> 1.8.5.3
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[PATCHv2] ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

[Jarkko Nikula]

Some kernel configurations can cause following build error:

sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
  memcpy_fromio(&fw_tstamp,
  ^
cc1: some warnings being treated as errors

Fix this by including <linux/io.h> explicitly.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
v2: including <linux/io.h> instead of <asm/io.h>. Thanks to Takashi Iwai for
noticing (checkpatch.pl tells it too).

Also sst-dsp., sst-baytrail-dsp.c and sst-haswell-dsp.c are using
memcpy_fromio/_toio but there <asm/io.h> seems to come via
<linux/dma-mapping.h> or <linux/io.h> so I didn't touch them.
---
 sound/soc/intel/sst-baytrail-ipc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/intel/sst-baytrail-ipc.c b/sound/soc/intel/sst-baytrail-ipc.c
index 8c91a68b90bc..c12e194bbc6b 100644
--- a/sound/soc/intel/sst-baytrail-ipc.c
+++ b/sound/soc/intel/sst-baytrail-ipc.c
@@ -26,6 +26,7 @@
 #include <linux/platform_device.h>
 #include <linux/kthread.h>
 #include <linux/firmware.h>
+#include <linux/io.h>
 #include <asm/div64.h>
 
 #include "sst-baytrail-ipc.h"
-- 
1.8.5.3

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCHv2] ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 463 bytes --]

On Wed, Feb 26, 2014 at 03:31:46PM +0200, Jarkko Nikula wrote:
> Some kernel configurations can cause following build error:
> 
> sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
> sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
>   memcpy_fromio(&fw_tstamp,
>   ^
> cc1: some warnings being treated as errors

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]