Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH v4 4/5] ASoC: dapm: Rename soc_widget_update_bits_locked() to soc_widget_update_bits()
Date: Tue, 22 Apr 2014 13:23:16 +0200	[thread overview]
Message-ID: <1398165797-22997-5-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1398165797-22997-1-git-send-email-lars@metafoo.de>

There is no unlocked version of soc_widget_update_bits_locked() and there is no
plan to introduce it in the near future, so drop the _locked suffix.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 sound/soc/soc-dapm.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 85a594f..a2475e1 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -383,7 +383,7 @@ static int soc_widget_read(struct snd_soc_dapm_widget *w, int reg,
 	return snd_soc_component_read(w->dapm->component, reg, value);
 }
 
-static int soc_widget_update_bits_locked(struct snd_soc_dapm_widget *w,
+static int soc_widget_update_bits(struct snd_soc_dapm_widget *w,
 	int reg, unsigned int mask, unsigned int value)
 {
 	if (!w->dapm->component)
@@ -1070,7 +1070,7 @@ int dapm_reg_event(struct snd_soc_dapm_widget *w,
 	else
 		val = w->off_val;
 
-	soc_widget_update_bits_locked(w, -(w->reg + 1),
+	soc_widget_update_bits(w, -(w->reg + 1),
 			    w->mask << w->shift, val << w->shift);
 
 	return 0;
@@ -1366,7 +1366,7 @@ static void dapm_seq_run_coalesced(struct snd_soc_card *card,
 			"pop test : Applying 0x%x/0x%x to %x in %dms\n",
 			value, mask, reg, card->pop_time);
 		pop_wait(card->pop_time);
-		soc_widget_update_bits_locked(w, reg, mask, value);
+		soc_widget_update_bits(w, reg, mask, value);
 	}
 
 	list_for_each_entry(w, pending, power_list) {
@@ -1512,8 +1512,7 @@ static void dapm_widget_update(struct snd_soc_card *card)
 	if (!w)
 		return;
 
-	ret = soc_widget_update_bits_locked(w, update->reg, update->mask,
-				  update->val);
+	ret = soc_widget_update_bits(w, update->reg, update->mask, update->val);
 	if (ret < 0)
 		dev_err(w->dapm->dev, "ASoC: %s DAPM update failed: %d\n",
 			w->name, ret);
-- 
1.8.0

  parent reply	other threads:[~2014-04-22 11:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 11:23 [PATCH v4 0/5] ASoC: Move IO and kcontrols to the component level Lars-Peter Clausen
2014-04-22 11:23 ` [PATCH v4 1/5] ASoC: Move IO abstraction " Lars-Peter Clausen
2014-04-22 12:24   ` Mark Brown
2014-04-22 11:23 ` [PATCH v4 2/5] ASoC: Move standard kcontrol helpers " Lars-Peter Clausen
2014-04-22 12:38   ` Mark Brown
2014-05-09 15:00   ` Shawn Guo
2014-05-09 15:17     ` Lars-Peter Clausen
2014-05-09 15:34       ` Fabio Estevam
2014-05-09 16:01         ` Lars-Peter Clausen
2014-05-09 16:11           ` Fabio Estevam
2014-05-10  5:07           ` Shawn Guo
2014-05-10  7:04             ` Lars-Peter Clausen
2014-05-10  7:11               ` Lars-Peter Clausen
2014-05-10  8:31                 ` Shawn Guo
2014-05-10  8:37                   ` Lars-Peter Clausen
2014-05-10  9:12                     ` Shawn Guo
2014-05-10  9:28                       ` Lars-Peter Clausen
2014-05-12 10:42                       ` Charles Keepax
2014-05-12 11:03                         ` Mark Brown
2014-05-12 14:09                           ` Charles Keepax
2014-05-12 10:52                       ` Charles Keepax
2014-05-13  3:19                         ` Shawn Guo
2014-04-22 11:23 ` [PATCH v4 3/5] ASoC: Remove snd_soc_update_bits_locked() Lars-Peter Clausen
2014-04-22 12:25   ` Mark Brown
2014-04-22 11:23 ` Lars-Peter Clausen [this message]
2014-04-22 12:25   ` [PATCH v4 4/5] ASoC: dapm: Rename soc_widget_update_bits_locked() to soc_widget_update_bits() Mark Brown
2014-04-22 11:23 ` [PATCH v4 5/5] ASoC: Remove ASoC level IO tracing Lars-Peter Clausen
2014-04-22 12:25   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398165797-22997-5-git-send-email-lars@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox